Commit Graph

13 Commits

Author SHA1 Message Date
Jeff Morriss bb61772be7 From Dirk: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2930 :
Make the image (png, gif, jfif) dissectors "new style" so that they don't
dissect data that does not belong to them.

Modify the HTTP dissector to call heuristic dissectors on the body if the
registered subdissector does not accept/dissect the data.

From me: don't use assert() and don't add a preference to the HTTP dissector
for this behavior: it makes sense to behave like that by default.

svn path=/trunk/; revision=36305
2011-03-24 02:49:05 +00:00
Stephen Fisher b494b86514 From Dirk via bug #5771: Add heuristic dissector for images and HTTP
Also add to AUTHORS file.


svn path=/trunk/; revision=36253
2011-03-22 16:43:16 +00:00
Kovarththanan Rajaratnam 00810ff199 * Prefer col_append_str instead of col_append_fstr for constant strings
* Remove check_col guards

svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Guy Harris 83fc9d5e09 Constify a bunch of stuff, to squelch -Wwrite-strings warnings.
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not
ready to enable that warning by default yet.

Throw in some casts to handle GLib routines that take arbitrary
non-const pointers (they can later return the pointers, and some
callers might want to modify or free up those pointers in cases where
they're known to be writable or allocated).

Use ep_tvb_memdup() rather than a combination of ep_alloc() and
tvb_memcpy().

Clean up some indentation.

svn path=/trunk/; revision=25601
2008-06-25 09:12:35 +00:00
Bill Meier 444602bf97 Oops: wireshark.com --> wireshark.org
Also: 1 additional Ethereal --> Wireshark

svn path=/trunk/; revision=20272
2007-01-02 17:19:25 +00:00
Bill Meier 739eb43c3a More ethereal --> wireshark
svn path=/trunk/; revision=20270
2007-01-02 14:11:35 +00:00
Ulf Lamping cb29acb89a don't replace the COL_PROTO and COL_INFO entries simply with "PNG", but append it only to the COL_INFO just like the GIF dissector is doing
this keeps valuable info in COL_INFO, e.g. the HTTP status code 

svn path=/trunk/; revision=19308
2006-09-24 00:45:31 +00:00
Gerald Combs 8961a58ee1 Don't abort the entire program if we have bad data. Just mark the
packet as malformed and continue on our merry way.  This should fix
bugs 1064 - 1073.

Fix up whitespace.

svn path=/trunk/; revision=19057
2006-08-28 02:06:28 +00:00
Ronnie Sahlberg a5f6c6cdbf two more chunks
svn path=/trunk/; revision=19045
2006-08-26 12:26:19 +00:00
Ronnie Sahlberg 318b5d8e99 fix wrong constant in a valuestring
add two more chunks to be dissected


svn path=/trunk/; revision=19044
2006-08-26 11:57:28 +00:00
Ronnie Sahlberg 39d99904f8 initial PNG dissector (Portable Network Graphics)
svn path=/trunk/; revision=19042
2006-08-26 09:16:38 +00:00