Commit Graph

22802 Commits

Author SHA1 Message Date
Anders Broman 03c7a3c920 Apply yet another set of the optimization patches:
Use O(1) logic for the fast path when adding fragments (ie fragments are in order).

svn path=/trunk/; revision=23422
2007-11-10 16:08:14 +00:00
Sake Blok 508e268063 This patch makes it possible to disable individual coloring rules
without having to delete them. The patch has been tested on
Fedora-7 with GTK+ 1.2.10 and GTK+ 2.10.11.

Since I don't know how to use "strikethrough" in clists in GTK1
there is a little difference in how the disabled coloring rules
are displayed. In GTK2 they are striked through and in GTK1
they are shown in lightgrey on a white background.

Any info on how to use strikthrough in clists within GTK1 is more
than welcome :-)


svn path=/trunk/; revision=23421
2007-11-10 15:18:49 +00:00
Guy Harris 5057a3a763 Quote a "Checking for" message.
svn path=/trunk/; revision=23420
2007-11-10 02:39:19 +00:00
Guy Harris 6862f071bc Update comment, clean up message.
svn path=/trunk/; revision=23419
2007-11-10 02:18:18 +00:00
Stephen Fisher 432aa1788a Add MacOS X version next to the Darwin version in version outputs.
svn path=/trunk/; revision=23418
2007-11-10 00:57:41 +00:00
Guy Harris 6f1740aa6c Cast "char"s to "unsigned char" before handing them to <ctype.h> macros.
svn path=/trunk/; revision=23417
2007-11-10 00:36:01 +00:00
Gerald Combs 1c9158a00e Add a newline.
svn path=/trunk/; revision=23416
2007-11-09 20:05:44 +00:00
Gerald Combs 8e45bbf506 Don't call tvb_set_child_real_data_tvbuff() + add_new_data_source() twice
for the same tvb.  This keeps us from freeing the same memory twice and
crashing on some systems.

This might be the same bug Brian Vandenberg was looking for in
http://www.wireshark.org/lists/wireshark-dev/200705/msg00406.html .

svn path=/trunk/; revision=23415
2007-11-09 20:04:40 +00:00
Martin Mathieson 0f63de9281 From Stephen Croll.
Dynamically register filter fields from TLV definitions.

svn path=/trunk/; revision=23414
2007-11-09 14:41:04 +00:00
Anders Broman b421cc6a2c Apply yet another set of the optimization patches:
move the case where pinfo->in_error_pkt is true in its own function:
- it's not the common case.
- it needs a TRY block. ==> slow volatile and big stack footprint.
- call_dissector_work is called a lot and recursively.

svn path=/trunk/; revision=23413
2007-11-09 06:07:30 +00:00
Anders Broman 6226035893 Apply yet another set of the optimization patches:
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length().

On the other hand 
	if (tvb_bytes_exist(tvb, 0, 20)
is more readable than
	if (tvb_length(tvb) >= 20

so only do it in heuristic function

svn path=/trunk/; revision=23412
2007-11-09 06:01:18 +00:00
Anders Broman 29cf34d1c2 Apply yet another set of the optimization patches:
janitor work, replace col_add_fstr/ col_set_fstr.

svn path=/trunk/; revision=23411
2007-11-09 05:57:45 +00:00
Anders Broman 9da07f5246 Apply yet another set of the optimization patches:
Only call get_hostname once.

svn path=/trunk/; revision=23410
2007-11-09 05:56:42 +00:00
Anders Broman b325ef4878 Apply yet another set of the optimization patches:
Don't use g_snprintf for temporary unsigned int to ascii conversion.

svn path=/trunk/; revision=23409
2007-11-09 05:55:33 +00:00
Anders Broman 377793fc54 Apply yet another set of the optimization patches:
small memory leak when freeing compiled filter insns.

svn path=/trunk/; revision=23408
2007-11-09 05:54:16 +00:00
Stephen Fisher eae32f15eb Back out part of revision 23395 - leave the toolbar arrow, but remove the
preference to turn it on / off per discussion on -dev list.


svn path=/trunk/; revision=23407
2007-11-09 02:08:00 +00:00
Anders Broman 9d316093f6 Apply yet another set of the optimization patches:
-set_str2add_str_val_to_str

svn path=/trunk/; revision=23406
2007-11-08 22:49:03 +00:00
Anders Broman 90753a169e Apply yet another set of the optimization patches:
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length().
non heuristic dissectors

svn path=/trunk/; revision=23405
2007-11-08 22:40:20 +00:00
Anders Broman 94859ac29b Apply yet another set of the optimization patches:
if tree is not NULL then proto_xxx_add_yyy functions can't return NULL.
Remove always true tests.

svn path=/trunk/; revision=23404
2007-11-08 22:39:01 +00:00
Anders Broman 4d07f32a41 Apply yet another set of the optimization patches:
- Move proto_tree_add_xxxx calls inside 'if (tree) {}' block

svn path=/trunk/; revision=23403
2007-11-08 22:38:06 +00:00
Anders Broman 7b3debb40d Change dissecton of address type for AVP < 256 (RADIUS address).
svn path=/trunk/; revision=23402
2007-11-08 22:36:19 +00:00
Jeff Morriss 0d07277007 Don't cast pinfo->src.data to (const mtp3_addr_pc_t *) unless we *know* it's
an MTP3 PC in there (else we get a bus error on SPARC systems).
If we don't have MTP3 PC addresses hash on address_to_str(&pinfo->src).  This
makes TCAP statistics work over SUA.

svn path=/trunk/; revision=23401
2007-11-08 19:13:51 +00:00
Anders Broman b3aab48e2a - "Location-Information" is grouped.
- Add TS 183 033 V1.2.0 (2007-10) AVP:s

svn path=/trunk/; revision=23400
2007-11-08 17:24:17 +00:00
Gerald Combs cd7cc1557e Move SKIP_CAPTURE from suite-capture.sh to config.sh so that we can use it
in suite-clopts as well.  Allow it to be set externally.  This should fix
the "test" failure in the Solairs builder.

svn path=/trunk/; revision=23399
2007-11-08 16:59:30 +00:00
Gerald Combs 4105173f0e Fix a couple of integer underflows.
svn path=/trunk/; revision=23398
2007-11-08 05:54:29 +00:00
Stephen Fisher ee3d03b7ae Fix Windows builds that cannot find gtk/gtk.h from epan/prefs.c. Write out
toolbar arrow preference even in GTK < 2.4 and just don't use it unless
running GTK 2.4+.


svn path=/trunk/; revision=23397
2007-11-08 02:29:18 +00:00
Gerald Combs 544ca516b5 Add more TCP analysis struct checks.
svn path=/trunk/; revision=23396
2007-11-08 00:58:38 +00:00
Stephen Fisher d7c1ba361f Add an arrow with drop-down menu including any toolbar buttons that do not
fit on the top of the screen.  This only works in GTK 2.4+ and there is
a layout preference setting to disable it.


svn path=/trunk/; revision=23395
2007-11-07 21:50:48 +00:00
Anders Broman 079e1446f9 Update to use the -X and -T asn2wrs flags.
svn path=/trunk/; revision=23394
2007-11-07 21:22:25 +00:00
Gerald Combs 75a21280ea Back out r23308 for the time being, since it's making hhc.exe on the Windows
builder crash.

svn path=/trunk/; revision=23393
2007-11-07 20:13:40 +00:00
Stig Bjørlykke 2e98c04584 Create a subset tvb for dissect_x411_ORName so it doesn't eat too much data.
Removed some unnecessary int casts.

svn path=/trunk/; revision=23392
2007-11-07 20:03:29 +00:00
Jörg Mayer e47e42e10e Add VID VID_draft_ietf_ipsec_nat_t_ike_01, move
VID_draft_ietf_ipsec_nat_t_ike_03 a bit down.

svn path=/trunk/; revision=23391
2007-11-07 18:35:00 +00:00
Anders Broman ce2a32dc6f Update to use the -X and -T asn2wrs flags.
svn path=/trunk/; revision=23390
2007-11-07 17:55:57 +00:00
Anders Broman c822748454 Delete obsolete dissectors.
svn path=/trunk/; revision=23389
2007-11-07 17:55:06 +00:00
Jörg Mayer 9491dc16f1 Print VendorID string in payload summary line
svn path=/trunk/; revision=23388
2007-11-07 17:23:28 +00:00
Jörg Mayer c59a75bee0 Add two sentences clarifying the license statement on pidl:
As a notable exception the pidl utility at tools/pidl is covered by a
"GPL version 3 or later" LICENSE. Note that only the tool itself
is covered by this license, not the source code generated by it. The
pidl authors do not consider that code a derived work of pidl.


svn path=/trunk/; revision=23387
2007-11-06 22:01:20 +00:00
Anders Broman fb00aa074f as2wrs now handles EXTERNAL(direct-reference requires no special handling).
svn path=/trunk/; revision=23386
2007-11-06 21:52:26 +00:00
Gerald Combs 6e207e3f34 When checking to see if we should install WinPcap, check the installed
version directly instead of trying to divine it from its name. 

svn path=/trunk/; revision=23385
2007-11-06 20:32:30 +00:00
Anders Broman e0937a5992 as2wrs now handles EXTERNAL(direct-reference requires no special handling).
svn path=/trunk/; revision=23384
2007-11-06 20:26:13 +00:00
Anders Broman 998eabe31f as2wrs now handles EXTERNAL(direct-reference requires no special handling).
svn path=/trunk/; revision=23383
2007-11-06 20:21:09 +00:00
Anders Broman 2555a2f6fb as2wrs now handles EXTERNAL(direct-reference requires no special handling).
svn path=/trunk/; revision=23382
2007-11-06 20:16:59 +00:00
Jörg Mayer 624b58c099 Add a remark that the code under tools/pidl/ is covered
by GPLv3 (inside the files it only says GPL).

svn path=/trunk/; revision=23381
2007-11-06 20:03:22 +00:00
Anders Broman d3028865d3 From Keith Mercer:
CFM dissector bugfixes and code update for ITU inclusion

svn path=/trunk/; revision=23380
2007-11-06 19:47:38 +00:00
Anders Broman 5cd9fcc943 From Florent Drouin:
Fix bug Some Toshiba format files with LAPD cannot be open
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1711

svn path=/trunk/; revision=23379
2007-11-06 19:22:51 +00:00
Jörg Mayer b349ff3e87 Update from samba tree revision 25306 to 25880
============================ Samba log start ============
------------------------------------------------------------------------
r25453 | jelmer | 2007-10-01 23:38:15 +0200 (Mon, 01 Oct 2007) | 1 line

Fix include for NTSTATUS.
------------------------------------------------------------------------
r25457 | jelmer | 2007-10-02 06:45:25 +0200 (Tue, 02 Oct 2007) | 1 line

use different location for out-of-tree builds
------------------------------------------------------------------------
r25674 | metze | 2007-10-17 10:26:55 +0200 (Wed, 17 Oct 2007) | 13 lines

fix crash bug in pidl generated client code, this
could have happend with [in,out,unique] pointers
when the clients sends a valid pointer, but the server
reponse with a NULL pointer (as samba-3.0.26a do for some calls).

I've tested with midl to see how windows handles this situation
and also the reverse case where the client sends NULL and
the server reposnse with non-NULL.

It appears that midl generated code just ignores this
and only copies the result if both pointers are non-NULL.

metze
------------------------------------------------------------------------
r25700 | jra | 2007-10-19 02:40:51 +0200 (Fri, 19 Oct 2007) | 3 lines

Now BOOL no longer exists in Samba 3.2, use bool instead.
Jeremy.

------------------------------------------------------------------------
r25745 | metze | 2007-10-27 11:57:09 +0200 (Sat, 27 Oct 2007) | 6 lines

[pidl] ndr_pull/push_error(ndr, NDR_ERR_INVALID_POINTER,..)

instead NT_STATUS_INVALID_PARAMETER_MIX

metze

------------------------------------------------------------------------
r25751 | metze | 2007-10-30 07:24:43 +0100 (Tue, 30 Oct 2007) | 4 lines

use EJS_CHECK() instead of NDR_CHECK() in ejs code

metze

------------------------------------------------------------------------
r25765 | metze | 2007-10-31 17:25:44 +0100 (Wed, 31 Oct 2007) | 3 lines

pidl: fix compiler warning in ndr_align test

metze
------------------------------------------------------------------------
r25766 | metze | 2007-10-31 17:27:21 +0100 (Wed, 31 Oct 2007) | 3 lines

pidl: fix bugs in ndr_tagtype tests found by compiler warnings

metze
------------------------------------------------------------------------
r25767 | metze | 2007-10-31 17:29:32 +0100 (Wed, 31 Oct 2007) | 5 lines

pidl: make it easier to debug errors in pidl tests

we now print the C program that we tried to compile

metze
------------------------------------------------------------------------
r25768 | metze | 2007-10-31 17:44:42 +0100 (Wed, 31 Oct 2007) | 5 lines

pidl: NT_STATUS_IS_ERR() is NOT the same as !NT_STATUS_IS_OK()

Everything but success should be handled as error in the tests.

metze
------------------------------------------------------------------------
r25795 | metze | 2007-11-02 11:35:09 +0100 (Fri, 02 Nov 2007) | 3 lines

whitespace cleanup...

metze
------------------------------------------------------------------------
r25804 | metze | 2007-11-02 14:02:25 +0100 (Fri, 02 Nov 2007) | 4 lines

move including ndr_compression.h into HeaderInterface()

metze

------------------------------------------------------------------------
r25805 | metze | 2007-11-02 14:05:43 +0100 (Fri, 02 Nov 2007) | 4 lines

pidl: include libndr.h as first header in ndr_foo.h

metze

------------------------------------------------------------------------
r25806 | metze | 2007-11-02 14:48:11 +0100 (Fri, 02 Nov 2007) | 5 lines

let libndr.h include needed stuff and remove pidl magic
for choosing common required headers

metze

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

svn path=/trunk/; revision=23378
2007-11-06 18:31:26 +00:00
Anders Broman a1347fde05 Set up RTP conversation when PORT is known.
svn path=/trunk/; revision=23377
2007-11-06 18:11:20 +00:00
Anders Broman e69d68f57d Fix some typos.
svn path=/trunk/; revision=23376
2007-11-06 18:10:34 +00:00
Guy Harris d913f45ef1 Fix bug 1956 - make the bitwise-AND routine treat its arguments as being
IPv4 addresses.  Also, rename that routine to cmp_bitwise_and(), as it's
not working on bit strings.

svn path=/trunk/; revision=23375
2007-11-06 09:19:59 +00:00
Guy Harris 69ba6c7762 The "bitwise AND" display filter operator is supposed to evaluate to
TRUE if the result of the operation has any bit set; that means that the
test should stop and return TRUE as soon as it finds two bytes that when
ANDed together are non-zero, and return FALSE if no such byte was found.

The other test functions don't have "_bytes" in the routine name; don't
put it into this one.

svn path=/trunk/; revision=23374
2007-11-06 08:46:57 +00:00
Ronnie Sahlberg 7885237398 add a g_byte_array_sized_new() helper if we compile for glib < 2
svn path=/trunk/; revision=23373
2007-11-06 05:51:49 +00:00