8d802d414c
Make sure that we point the current column to a constant string if we have no address.
...
Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=20&rev2=21
svn path=/trunk/; revision=29860
2009-09-11 14:21:04 +00:00
129f907f0c
Move some CHECK_COL to our public functions, allowing us to bail our more quickly
...
svn path=/trunk/; revision=29859
2009-09-11 14:00:36 +00:00
de23d92163
Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter.
...
svn path=/trunk/; revision=29806
2009-09-08 19:00:54 +00:00
d713b846e6
Hoist COL_CHECK_REF_TIME in the call hierarchy. Use it in our public functions, not our internal functions
...
svn path=/trunk/; revision=29798
2009-09-08 15:55:10 +00:00
d75778eb4a
Custom columnfication:
...
* Deprecate COL_DCE_CTX ("Context ID). Use dcerpc.cn_ctx_id
svn path=/trunk/; revision=29797
2009-09-08 14:59:26 +00:00
bc845e056c
Custom column deprecation:
...
We fill out the COL_DSTIDX column by using 'pinfo->dst_idx'. This member is only set by the MDS Header dissector based on 'mdshdr.dstidx'. So remove COL_DSTIDX and migrate to 'mdshdr.dstidx' custom column.
svn path=/trunk/; revision=29795
2009-09-08 14:29:08 +00:00
62af6eff84
Custom column deprecation:
...
We fill out the COL_SRCIDX column by using 'pinfo->src_idx'. This member is only set by the MDS Header dissector based on 'mdshdr.srcidx'. So remove COL_SRCIDX and migrate to 'mdshdr.srcidx' custom column.
svn path=/trunk/; revision=29794
2009-09-08 14:26:09 +00:00
2cf14900d2
Custom column deprecation:
...
We fill out the COL_RXID column by using 'pinfo->rxid'. This member is only set by the Fibre Channel dissector based on 'fc.rx_id'. So remove COL_RXID and migrate to 'fc.rx_id' custom column.
svn path=/trunk/; revision=29793
2009-09-08 14:21:14 +00:00
cdfeebdd26
Custom column deprecation:
...
We fill out the COL_OXID column by using 'pinfo->oxid'. This member is only set by the Fibre Channel dissector based on 'fc.ox_id'. So remove COL_OXID and migrate to 'fc.ox_id' custom column.
svn path=/trunk/; revision=29792
2009-09-08 14:17:36 +00:00
c6d4c80371
From : Didier Gautheron
...
speed up a little proto_custom_set.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3972
svn path=/trunk/; revision=29789
2009-09-08 10:33:15 +00:00
65e2d90058
Remove an unused parameter.
...
svn path=/trunk/; revision=29784
2009-09-08 04:50:48 +00:00
3efea601d4
Make sure that we fill in the frame_data before passing it onto col_fill_in_frame_data
...
svn path=/trunk/; revision=29780
2009-09-07 19:43:05 +00:00
72c9662da6
ntroduce some seasonal address name lookup functions which we use when NEW_PACKET_LIST is defined. This change partially reverts some parts of r29768, which didn't seem to work because it assumed that get_addr_name() would always return a seasonal string. This wasn't the case if the adddress type was AT_STRINGZ.
...
svn path=/trunk/; revision=29771
2009-09-07 16:05:37 +00:00
2fe83ebaed
mark unused parameter.
...
svn path=/trunk/; revision=29769
2009-09-07 15:01:51 +00:00
3abd049a9b
Use constant strings for Addresses saves some memory.
...
svn path=/trunk/; revision=29768
2009-09-07 14:03:05 +00:00
c7eb52b086
Remove already #if 0'ed code that was made redundant due to COL_CIRCUIT_ID custom column deprecation
...
svn path=/trunk/; revision=29745
2009-09-06 13:35:27 +00:00
bfe9f61a7c
Remove static custom column variable which is no longer used
...
svn path=/trunk/; revision=29744
2009-09-06 13:25:31 +00:00
09237c27f9
Inline col_has_time_fmt() into col_based_on_frame_data()
...
svn path=/trunk/; revision=29739
2009-09-06 10:03:06 +00:00
474f5930db
Macrofy have_custom_cols() -> HAVE_CUSTOM_COLS() internally in columns-utils.c
...
svn path=/trunk/; revision=29737
2009-09-06 09:11:17 +00:00
22077a8eb1
Macrofy check_col() -> CHECK_COL() internally in columns-utils.c
...
svn path=/trunk/; revision=29736
2009-09-06 09:03:15 +00:00
7d4cf0b966
col_custom_set_fstr() is unused. Remove it
...
svn path=/trunk/; revision=29722
2009-09-05 18:45:55 +00:00
a108023b2a
COL_BSSGP_TLLI is deprecated
...
svn path=/trunk/; revision=29721
2009-09-05 18:39:46 +00:00
7e8455ff63
Reorder col_fill_in()
...
svn path=/trunk/; revision=29720
2009-09-05 18:28:06 +00:00
b076f98b46
Show correct time value for "Time since previous displayed frame".
...
svn path=/trunk/; revision=29572
2009-08-26 22:31:06 +00:00
32e7cddf70
From Didier Gautheron:
...
move custom col set from proto_tree_set_xxx() to
epan_dissect_fill_in_columns().
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3930
I'v added the new functions to the .h files.
svn path=/trunk/; revision=29551
2009-08-25 21:10:35 +00:00
23d4eba3b1
Custom columnfication:
...
* Deprecate COL_DELTA_CONV_TIME (Delta time (conversation)). Use tcp.time_delta
svn path=/trunk/; revision=29524
2009-08-23 12:30:48 +00:00
b9cbd15469
Custom columnfication:
...
* Deprecate COL_REL_CONV_TIME (Relative time (conversation)). Use tcp.time_relative
svn path=/trunk/; revision=29523
2009-08-23 12:24:14 +00:00
55cf35e3a0
Custom columnfication:
...
* Deprecate COL_FR_DLCI (Frame Relay DLCI). Use fr.dlci
svn path=/trunk/; revision=29522
2009-08-23 12:16:10 +00:00
1a7b6733cd
#if 0 col_set_circuit_id(). It isn't being used
...
svn path=/trunk/; revision=29519
2009-08-23 11:13:53 +00:00
51ca1739ae
Custom columfication:
...
* Deprecate COL_DSCP_VALUE (IP DSCP Value). Use ip.dsfield
svn path=/trunk/; revision=29518
2009-08-23 11:12:12 +00:00
00670c55c6
Custom columfication:
...
* Deprecate COL_HPUX_DEVID (HP-UX Device ID). Use nettl.devid
svn path=/trunk/; revision=29517
2009-08-23 10:25:51 +00:00
205129d25c
Custom columfication:
...
* Deprecate COL_HPUX_SUBSYS (HP-UX Nettl Subsystem). Use nettl.subsys
svn path=/trunk/; revision=29516
2009-08-23 10:20:42 +00:00
56369978ae
Custom columfication:
...
* Deprecate COL_CIRCUIT_ID (Circuit ID). Use iax2.call
svn path=/trunk/; revision=29515
2009-08-23 09:52:57 +00:00
6b89de8393
Custom columfication:
...
* Deprecate COL_COS_VALUE (L2 COS Value (802.1p)). Use vlan.priority
svn path=/trunk/; revision=29513
2009-08-23 09:07:54 +00:00
3d740a490f
We initialize col_expr and col_expr_val in col_init() so there's no need to initialize them again in col_set_xxx()
...
svn path=/trunk/; revision=29507
2009-08-22 19:29:44 +00:00
1108352f00
Use col_text in frame data.
...
- colum-utils needs more work, based on
Didier Gautherons optimizations patch http://wiki.wireshark.org/Development/Optimization
svn path=/trunk/; revision=29489
2009-08-21 10:12:47 +00:00
100aeddafe
From Didier Gautheron:
...
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Make col_expr const gchar.
svn path=/trunk/; revision=29471
2009-08-19 07:55:11 +00:00
a1a129abb5
Prepare to store column data from pinfo.
...
svn path=/trunk/; revision=29454
2009-08-17 15:05:43 +00:00
ca335d25cb
From Kovarththanan Rajaratnam:
...
- Compute and cache color/custom filters dynamically.
- Delay column construction.
svn path=/trunk/; revision=29370
2009-08-10 20:52:56 +00:00
cb771536df
From Kovarththanan Rajaratnam:
...
Only fill in frame_data vals when needed.
svn path=/trunk/; revision=29203
2009-07-27 08:33:26 +00:00
9ca4ac2bed
From Kovarththanan Rajaratnam:
...
Use frame_data values .
svn path=/trunk/; revision=29202
2009-07-27 03:34:57 +00:00
733bdd4e56
Try to get the #includes right - take 2.
...
svn path=/trunk/; revision=29176
2009-07-23 08:53:13 +00:00
b4a0cda41e
Try to get the #includes right.
...
svn path=/trunk/; revision=29175
2009-07-23 07:57:32 +00:00
ded297677f
From Kovarththanan Rajaratnam:
...
Precompile custom columns filters.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3767
svn path=/trunk/; revision=29174
2009-07-23 05:48:39 +00:00
c570bf42e2
Change some g_malloc() calls to g_new() to make the code easier to read.
...
svn path=/trunk/; revision=29162
2009-07-22 05:02:24 +00:00
8c4abdfb47
From didier gautheron via bug 3762:
...
This patch removes col_expr in frame_data structure,
it can be recomputed when needed.
svn path=/trunk/; revision=29159
2009-07-21 16:48:16 +00:00
6348c17c16
size_t fixes.
...
svn path=/trunk/; revision=27984
2009-04-07 16:36:52 +00:00
825f3d64e0
Put check_col() in each column util function, as discussed in bug 2902.
...
This will eliminate some problems when not checking before calling the
functions, and makes the dissector code looks cleaner.
Cleaning up the dissectors is TBD.
svn path=/trunk/; revision=27806
2009-03-20 12:41:03 +00:00
965448f3e7
From Jakub Zawadzki (bug 3334):
...
Fix typo in filter name for frame.len (Packet length column).
svn path=/trunk/; revision=27721
2009-03-15 13:50:42 +00:00
acdf91e263
Make "Copy as Filter" on the packet list actually work.
...
Up till now every packet in the packet list got a copy of the pointer to the filter expressions for
the last packets' columns. Hence any 'Copy as Filter" on a column got the expression of the last
packet in the packet list. Instead every packet needs to get a pointer to the filter expressions
for its own columns. This requires making a copy of the filter expressions themselves.
Since this is a bug in 1.0 as well the GLIB1 code is provided for backporting, which can later be dropped from the development tree.
svn path=/trunk/; revision=27396
2009-02-09 07:10:46 +00:00
Kovarththanan Rajaratnam