Add an initial Clang-Tidy configuration file which checks for recursion
and various clang analyzer issues.
Run Clang-Tidy in the "Clang + Code Checks" merge request job.
Add NOLINT suppressions where needed in wsutil, epan, and lemon.
Continue to write the format-based hidden preference for now.
Read both preferences; if the index-based preference is read, use it.
If not, fall back to the format-based preference.
Followup to 41930060b0
We already do so for DL Data blocks, and it's useful as well for DL
Control blocks, in order to easily follow the communication between the
PCU and the scheduled TBF of each MS.
The matches operator implicitly converts non-stringlike fields
that have value strings to their value string value. (This is
not the same as the string representation of the number, which
applying the string function first would do, but it usually less
useful and worse performance than using numeric comparisons.)
However, FT_FRAMENUM fields have a hfinfo->strings but it is not
strings used for conversion, it is an overload with the special
ft_framenum_type_t, so don't convert.
This prevents a segmentation fault if expressions with
expressions like 'gtp.response_in ~ "test"'
Do not change the preference pointer inside the Extcap Options
Dialog. That changes the real preference value, which disturbs
the check inside prefs_store_ext_multiple that storeValues() calls
for whether a pref has changed or not. Since the prefs are already
changed to their new value, we won't realize that we need to write
out a new preference file.
The other changes in #18487 are sufficent to fix the problem
identified there (though it's a bit unclear what "required" means
in combination with a default, and whether we have to send the
default value for the required parameter or can omit it.)
If the button says "Save", then save the preferences regardless
of what the "extcap Save on Start" preference says.
Fix#19639. Related to #18487
If the capture.no_extcap preference is set, really don't load the
extcap interfaces. Previously, the extcap interfaces were loaded
before the preference was read, because otherwise the extcap
preferences wouldn't be registered and properly read out of the
configuration file.
Wait until after that preference is read to register the
extcap preferences and then re-read just the extcap module
preferences from the configuration files. Make sure to check
other times when the preference may be changed, such as
switching profiles.
Write extcap prefs to a separate file so that they don't get lost
if the extcap interfaces aren't loaded and the prefs are then
written out. Continue writing them to the main file for backwards
compability.
Related to #15295. Cuts ~100 ms off the loading time of Wireshark
in a normal situation if the capture.no_extcap preference is set,
more if an extcap has some kind of issue that makes it take a long
time to load.
Implement checking the ESP ICV when Extended Sequence Numbers are
used. Add some entries to the UAT, with forwards compability, for
the sequence number size, which is transmitted out of band.
Fix#19658
Remove CFBundleGetInfoString, which is deprecated, in favor of
NSHumanReadableCopyright. Use the same organization name there as we do
in our Windows resource files.
Ping #14407
The solution to #12331 makes command line options that change
preferences be reapplied when reloading Lua plugins.
The command line preference overrides should be either reapplied
or dropped when changing configuration profiles. Doing neither,
as currently, means that they are not reapplied when switching
but are reapplied when subsequently reloading Lua plugins, which
is confusing. Drop them, but we could change that decision.
Make sure that we set the pointer to NULL when freeing so that
we don't double-free.
commandline.h requires cfile.h to get the search direction enum.
Rather than shelling out to "osascript" and telling it to tell Finder to show
the file, we can directly use NSWorkspace's "activateFileViewerSelectingURLs:"
method to launch Finder and highlight the chosen file. It's less code, runs
faster, and should be much less risky regarding special characters, string
encodings, etc.
extcap_foreach no longer exists. The extcap_cb_t is used with
extcap_run_one, and when operations are needed on multiple
extcaps they are run in parallel in multiple threads, since each
operations requires spawning a process.
Update the comments to note this, and that the return value is
no longer used.
Allow cb_preference to take a NULL for the pointer to a list
of arguments. If the pointer is NULL, then free the argument list.
This keeps extcap_load_interface_list from creating a list that
is immediately freed.
On Linux (and presumably other DBus-using Unix-like OSes), right-clicking on a
file on the Welcome page and choosing "Show in Folder" would only ever open the
folder, and would not highlight the chosen file.
Adding DBus support to function desktop_show_in_folder allows for the file
itself to be shown -- subject to support from the user's desktop environment...
Read the old obsolete hidden column preference and apply it.
This will convert it to the new value (and remove it) if preferences
are saved.
Follow up to 41930060b0
Allow anything that can be used in a display filter to be used in
columns (with the exception that field references don't work without
a notion of a currently selected frame): display filter functions,
slices, arithmetic calculations, logical tests, raw byte addressing,
the layer modifier, display filter macros, etc., alone or in
combination.
Show the results and generate filters. Note that "resolved" values are
not yet supported. They make conceptual sense for some expressions
(e.g., if the layer modifier only is used) but not for others.
Perhaps resolution could be done as a final step in the filter before
returning values.
It would also be useful to be able to get the expected return type
of an expression, so that the functions for right justifying a column
or sorting numerically could work. Right now the results are treated
as strings even if the return field values are numeric.
Multifield columns (i.e., concatenation of field values) are currently
implemented using the OR operator.For backwards compability, continue to
support that. When a true logical OR would give a different result,
surround the expression in parentheses, which the multifield columns did
not previously support (due to the regex used instead of full filter
grammar parsing.)
Perhaps in the future we should introduce a separate operator for
concatenation, possibly only used in column definitions and nowhere
else.
Update release notes.
Fix#7752. Fix#10154. Fix#15990. Fix#18588. Fix#19076.
Related to #16181 - it's now possibly to define new display filter
functions so that is essentially solved, though I suppose there's
always room for more built-in functions.
The register and coil numbers are a sequence of numbers starting from
the desired number (first register). This revision will change
the register item to a generated one without a direct link to the data.
Decode data in the function Write Single Register/Write Multiple Coils
to Value.
Fix bitmask for boolean value in Read/Write Coils/Inputs.
Closing #19635
Change our menu path separator to "//" similar to our filter buttons.
Change the "name" configuration element to "path", since it's a menu
path. Add a separate "title" element. This lets us use names like "Foo
I/O".
Since DRBD 9.2.6, a load-balancing transport is available for DRBD. This
is called "lb-tcp". Add support for dissecting this format.
This transport is a wrapper around the plain DRBD format. Each lb-tcp
packet contains part of this DRBD stream. The DRBD packets may be broken
across multiple lb-tcp packets. Conversely, one lb-tcp packet may
contain multiple DRBD packets.
One lb-tcp connection consists of multiple TCP streams. We cannot rely
on having all of these streams in the capture. Even when we do, it is
difficult to associate them with each other. Hence we decode each TCP
stream separately and accept that we may not be able to dissect every
DRBD packet fully.
In practice, most lb-tcp payloads do start on a DRBD packet boundary, so
the result is still very usable.
Gerald Combs
Pau Espin