osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

BGP: Check nhlen 

Only call tvb_bytes_to_str() when nhlen > 0

Fixes: #18248
This commit is contained in:
Uli Heilmeier 2022-08-06 22:14:32 +02:00 committed by A Wireshark GitLab Utility
parent da5603a0d0
commit f9cf0a0ae7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
epan/dissectors/packet-bgp.c
View File

@ -4507,7 +4507,9 @@ decode_mp_next_hop(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo, guint16
proto_item_append_text(ti, ": %s", wmem_strbuf_get_str(strbuf));
} else {
expert_add_info_format(pinfo, ti, &ei_bgp_length_invalid, "Unknown Next Hop length (%u byte%s)", nhlen, plurality(nhlen, "", "s"));
proto_item_append_text(ti, ": %s", tvb_bytes_to_str(pinfo->pool, tvb, offset, nhlen));
if (nhlen > 0) {
proto_item_append_text(ti, ": %s", tvb_bytes_to_str(pinfo->pool, tvb, offset, nhlen));
}
}
return length;