diff --git a/epan/dissectors/packet-pdcp-lte.c b/epan/dissectors/packet-pdcp-lte.c index 87459c77e0..ede84b15ef 100644 --- a/epan/dissectors/packet-pdcp-lte.c +++ b/epan/dissectors/packet-pdcp-lte.c @@ -215,14 +215,11 @@ static gboolean check_valid_key_string(const char* raw_string, char* checked_str guint written = 0; guint length = (gint)strlen(raw_string); - char error_str[256]; - /* Can't be valid if not long enough. */ if (length < 32) { if (length > 0) { - g_snprintf(error_str, 256, "PDCP LTE: Invalid key string (%s) - should include 32 ASCII hex characters (16 bytes) but only %u chars given", - raw_string, length); - *error = g_strdup(error_str); + *error = g_strdup_printf("PDCP LTE: Invalid key string (%s) - should include 32 ASCII hex characters (16 bytes) but only %u chars given", + raw_string, length); } return FALSE; @@ -243,21 +240,18 @@ static gboolean check_valid_key_string(const char* raw_string, char* checked_str checked_string[written++] = c; } else { - g_snprintf(error_str, 256, "PDCP-LTE: Invalid char '%c' given in key", c); - *error = g_strdup(error_str); + *error = g_strdup_printf("PDCP-LTE: Invalid char '%c' given in key", c); return FALSE; } } /* Must have found exactly 32 hex ascii chars for 16-byte key */ if (n 0) { - g_snprintf(error_str, 256, "PDCP NR: Invalid key string (%s) - should include 32 ASCII hex characters (16 bytes) but only %u chars given", - raw_string, length); - *error = g_strdup(error_str); + *error = g_strdup_printf("PDCP NR: Invalid key string (%s) - should include 32 ASCII hex characters (16 bytes) but only %u chars given", + raw_string, length); } return FALSE; } @@ -220,21 +217,18 @@ static gboolean check_valid_key_string(const char* raw_string, char* checked_str checked_string[written++] = c; } else { - g_snprintf(error_str, 256, "PDCP-NR: Invalid char '%c' given in key", c); - *error = g_strdup(error_str); + *error = g_strdup_printf("PDCP-NR: Invalid char '%c' given in key", c); return FALSE; } } /* Must have found exactly 32 hex ascii chars for 16-byte key */ if (n