osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

stat_tap_ui: remove leaks. 

Change-Id: If7a28ba305bed9f63f200f8a8a27a796f2df9c07
Reviewed-on: https://code.wireshark.org/review/20015
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
This commit is contained in:
Dario Lombardo 2017-02-12 00:04:31 +01:00 committed by Michael Mann
parent 897c750127
commit e2951a2ca8
6 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
epan/conversation_table.c
View File

@ -170,6 +170,7 @@ set_conv_gui_data(gpointer data, gpointer user_data)
ui_info.nparams = 0;
ui_info.params = NULL;
register_stat_tap_ui(&ui_info, table);
g_free((char*)ui_info.cli_string);
}
void conversation_table_set_gui_info(conv_gui_init_cb init_cb)

2
epan/stat_tap_ui.c
View File

@ -61,7 +61,7 @@ register_stat_tap_ui(stat_tap_ui *ui, void *userdata)
stat_cmd_arg *newsca;
newsca = wmem_new(wmem_epan_scope(), stat_cmd_arg);
newsca->cmd=ui->cli_string;
newsca->cmd= wmem_strdup(wmem_epan_scope(), ui->cli_string);
newsca->func=ui->tap_init_cb;
newsca->userdata=userdata;

1
ui/cli/tap-follow.c
View File

@ -505,6 +505,7 @@ follow_register(const void *key _U_, void *value, void *userdata _U_)
follow_ui.nparams = 0;
follow_ui.params = NULL;
register_stat_tap_ui(&follow_ui, follower);
g_free((char*)follow_ui.cli_string);
return FALSE;
}

1
ui/cli/tap-rtd.c
View File

@ -154,6 +154,7 @@ register_rtd_tables(const void *key _U_, void *value, void *userdata _U_)
ui_info.nparams = 0;
ui_info.params = NULL;
register_stat_tap_ui(&ui_info, rtd);
g_free((char*)ui_info.cli_string);
return FALSE;
}

2
ui/cli/tap-simple_stattable.c
View File

@ -148,7 +148,7 @@ register_simple_stat_tables(const void *key, void *value, void *userdata _U_)
ui_info.group = new_stat_tap->group;
ui_info.title = new_stat_tap->title; /* construct this from the protocol info? */
ui_info.cli_string = (const char*)key;
ui_info.cli_string = (char*)key;
ui_info.tap_init_cb = simple_stat_init;
ui_info.nparams = new_stat_tap->nparams;
ui_info.params = new_stat_tap->params;

1
ui/cli/tap-srt.c
View File

@ -180,6 +180,7 @@ register_srt_tables(const void *key _U_, void *value, void *userdata _U_)
ui_info.nparams = 0;
ui_info.params = NULL;
register_stat_tap_ui(&ui_info, srt);
g_free((char*)ui_info.cli_string);
return FALSE;
}