osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

SMB2: ipv4 address is stored in big endian 

when expanding QUERY_NETWORK_INTERFACE_INFO responses completely IPv4
addresses show up backwards. Fix this by setting the right
endianess (BE).

Change-Id: I94897290f4052bc1e2471bc26d72dce8012b3e3a
Reviewed-on: https://code.wireshark.org/review/36144
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
This commit is contained in:
Aurelien Aptel 2020-02-20 19:27:05 +01:00 committed by Alexis La Goutte
parent 1403c09105
commit de665417ab
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-smb2.c
View File

@ -6602,7 +6602,7 @@ dissect_windows_sockaddr_in(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *p
offset += 2;
/* IPv4 address */
proto_tree_add_item(sub_tree, hf_windows_sockaddr_in_addr, tvb, offset, 4, ENC_LITTLE_ENDIAN);
proto_tree_add_item(sub_tree, hf_windows_sockaddr_in_addr, tvb, offset, 4, ENC_BIG_ENDIAN);
proto_item_append_text(sub_item, ", IPv4: %s", tvb_ip_to_str(tvb, offset));
proto_item_append_text(parent_item, ", IPv4: %s", tvb_ip_to_str(tvb, offset));
offset += 4;