osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

From Don Westman via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6889 

CIP Motion parsing of set axis attribute list request is messing up attr data

parsing a CIP Motion 'Set Axis Attribute List' Request returns correct data for attribute ID, dimension and element size but 'attribute data' field retrieves the same data for each attribute in the list rather than the real data sent in the request.

From me :
Fix the typo error (use the wrong offset variable, need to use local_offset variable)



svn path=/trunk/; revision=41257
This commit is contained in:
Alexis La Goutte 2012-03-01 09:11:08 +00:00
parent 23ec82fae9
commit ddcb796878
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-cipmotion.c
View File

@ -1229,7 +1229,7 @@ dissect_set_axis_attr_list_request (tvbuff_t* tvb, proto_tree* tree, guint32 off
}
/* Display the value of this attribute */
proto_tree_add_item(attr_tree, hf_cip_attribute_data, tvb, offset + attribute_start, attribute_size, ENC_NA);
proto_tree_add_item(attr_tree, hf_cip_attribute_data, tvb, local_offset + attribute_start, attribute_size, ENC_NA);
/* Round the attribute size up so the next attribute lines up on a 32-bit boundary */
if (attribute_size % 4 != 0)