osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

AUTOSAR NM: In default configuration all CAN packets will be dissected 

The default value for the CAN-ID Mask is currently 0. If no config is
present, all comparisons would be always true. This leads to all CAN
packets are being dissected by this dissector by default.
This is a huge performance problem and surely not intended.

This patch sets the default of the CAN-ID Mask to 0xffffffff, so that
in the unconfigured case, only the CAN-ID 0 would be dissected.
This commit is contained in:
Dr. Lars Völker 2021-03-11 20:05:45 +01:00 committed by Wireshark GitLab Utility
parent 272ff625f5
commit dabf0af6b7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-autosar-nm.c
View File

@ -89,7 +89,7 @@ static gboolean g_autosar_nm_interpret_coord_id = FALSE;
/* Id and mask of CAN frames to be dissected */
static guint32 g_autosar_nm_can_id = 0;
static guint32 g_autosar_nm_can_id_mask = 0;
static guint32 g_autosar_nm_can_id_mask = 0xffffffff;
/* Relevant PDUs */
static range_t *g_autosar_nm_pdus = NULL;