osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

FP - Fix missing TFI bitmask 

Parsing of the TFI field was not ignoring the 3 leftmost bits.
Also updated the comment explaining his mask.

Change-Id: I98d6ab9bdec3ce4a8640ece560a467ddbd5b8d42
Reviewed-on: https://code.wireshark.org/review/21978
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
This commit is contained in:
Darien Spencer 2017-06-06 13:14:56 -07:00 committed by Pascal Quantin
parent 874f8ade9c
commit d66b4a369a
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
epan/dissectors/packet-umts_fp.c
View File

@ -5273,10 +5273,8 @@ fp_set_per_packet_inf_from_conv(conversation_t *p_conv,
/* Peek at the packet as the per packet info seems not to take the tfi into account */
for (i=0; i<fpi->num_chans; i++) {
tfi = tvb_get_guint8(tvb, offset);
/*TFI is 5 bits according to 3GPP TS 25.321, paragraph 6.2.4.4*/
/*tfi = tvb_get_bits8(tvb, offset*8, 5);*/
/*TFI is 5 bits according to 3GPP TS 25.427, paragraph 6.2.4.4*/
tfi = tvb_get_guint8(tvb, offset) & 0x1f;
if (pinfo->link_dir == P2P_DIR_UL) {
fpi->chan_tf_size[i] = p_conv_data->fp_dch_channel_info[i].ul_chan_tf_size[tfi];
fpi->chan_num_tbs[i] = p_conv_data->fp_dch_channel_info[i].ul_chan_num_tbs[tfi];