osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

PIDL (DCERPC dnsserver): enhance dissector 

* Fix -Wunused-function (Add functions to dnsserver.cnf with NOEMIT)
* Remove dissector DCERPC dnsserver from DIRTY list

Change-Id: Id1d4f43784bfbf417156353fd3254375365c35c8
Reviewed-on: https://code.wireshark.org/review/4323
Reviewed-by: Michael Mann <mmann78@netscape.net>
This commit is contained in:
Alexis La Goutte 2014-09-26 23:35:40 +02:00 committed by Michael Mann
parent 28ec9c29ea
commit d572634e0a
4 changed files with 7 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/CMakeLists.txt
View File

@ -167,6 +167,7 @@ set(PIDL_DISSECTOR_SRC
# dissectors/packet-dcerpc-budb.c
# dissectors/packet-dcerpc-butc.c
# dissectors/packet-dcerpc-drsuapi.c
dissectors/packet-dcerpc-dnsserver.c
dissectors/packet-dcerpc-dssetup.c
dissectors/packet-dcerpc-efs.c
dissectors/packet-dcerpc-frstrans.c
@ -180,7 +181,6 @@ set(PIDL_DISSECTOR_SRC
)
set(DIRTY_PIDL_DISSECTOR_SRC
dissectors/packet-dcerpc-dfs.c
dissectors/packet-dcerpc-dnsserver.c
dissectors/packet-dcerpc-eventlog.c
dissectors/packet-dcerpc-lsa.c
dissectors/packet-dcerpc-mapi.c

2
epan/dissectors/Makefile.common
View File

@ -49,6 +49,7 @@ PIDL_DISSECTOR_SRC = \
packet-dcerpc-budb.c \
packet-dcerpc-butc.c \
packet-dcerpc-dssetup.c \
packet-dcerpc-dnsserver.c \
packet-dcerpc-efs.c \
packet-dcerpc-frstrans.c \
packet-dcerpc-initshutdown.c \
@ -65,7 +66,6 @@ PIDL_DISSECTOR_SRC = \
#
DIRTY_PIDL_DISSECTOR_SRC = \
packet-dcerpc-dfs.c \
packet-dcerpc-dnsserver.c \
packet-dcerpc-drsuapi.c \
packet-dcerpc-eventlog.c \
packet-dcerpc-lsa.c \

26
epan/dissectors/packet-dcerpc-dnsserver.c
View File

@ -395,9 +395,6 @@ static const true_false_string DNS_RPC_NODE_FLAGS_DNS_RPC_FLAG_SUPPRESS_NOTIFY_t
"DNS_RPC_FLAG_SUPPRESS_NOTIFY is SET",
"DNS_RPC_FLAG_SUPPRESS_NOTIFY is NOT SET",
};
static int dnsserver_dissect_element_DNS_RPC_NAME_NameLength(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, dcerpc_info* di _U_, guint8 *drep _U_);
static int dnsserver_dissect_element_DNS_RPC_NAME_Name(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, dcerpc_info* di _U_, guint8 *drep _U_);
static int dnsserver_dissect_element_DNS_RPC_NAME_Name_(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, dcerpc_info* di _U_, guint8 *drep _U_);
static int dnsserver_dissect_element_DNS_RPC_RECORD_NODE_NAME_Name(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, dcerpc_info* di _U_, guint8 *drep _U_);
static int dnsserver_dissect_element_DNS_RPC_RECORD_UNION_NodeName(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, dcerpc_info* di _U_, guint8 *drep _U_);
static int dnsserver_dissect_element_DNS_RPC_RECORD_DataLength(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, dcerpc_info* di _U_, guint8 *drep _U_);
@ -1250,29 +1247,6 @@ dnsserver_dissect_bitmap_DNS_RPC_NODE_FLAGS(tvbuff_t *tvb _U_, int offset _U_, p
/* IDL: uint8 Name[NameLength]; */
/* IDL: } */
static int
dnsserver_dissect_element_DNS_RPC_NAME_NameLength(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, dcerpc_info* di _U_, guint8 *drep _U_)
{
offset = PIDL_dissect_uint8(tvb, offset, pinfo, tree, di, drep, hf_dnsserver_DNS_RPC_NAME_NameLength, 0);
return offset;
}
static int
dnsserver_dissect_element_DNS_RPC_NAME_Name(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, dcerpc_info* di _U_, guint8 *drep _U_)
{
return offset;
}
static int
dnsserver_dissect_element_DNS_RPC_NAME_Name_(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, dcerpc_info* di _U_, guint8 *drep _U_)
{
offset = PIDL_dissect_uint8(tvb, offset, pinfo, tree, di, drep, hf_dnsserver_DNS_RPC_NAME_Name, 0);
return offset;
}
/* IDL: struct { */
/* IDL: DNS_RPC_NAME Name; */

5
epan/dissectors/pidl/dnsserver.cnf
View File

@ -11,6 +11,11 @@ HF_FIELD hf_dnsserver_DNS_RPC_NAME_name "Name" "dnsserver.DNS_RPC_NAME.name" FT_
MANUAL dnsserver_dissect_element_DNS_RPC_NODE_RecordCount
MANUAL dnsserver_dissect_element_DNS_RPC_NODE_records
NOEMIT dnsserver_dissect_element_DNS_RPC_NAME_NameLength
NOEMIT dnsserver_dissect_element_DNS_RPC_NAME_Name
NOEMIT dnsserver_dissect_element_DNS_RPC_NAME_Name_
CODE START
#include "packet-smb-common.h"