osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

From Florian Lohoff: fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2376 (and hopefully the other complaints about RedbackLI grabbing packets that aren't RedbackLI) by strengthening the heuristics. 

svn path=/trunk/; revision=24878
This commit is contained in:
Jeff Morriss 2008-04-10 19:35:07 +00:00
parent 188543e98d
commit d4b67e68f4
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
epan/dissectors/packet-redbackli.c
View File

@ -176,6 +176,7 @@ redbackli_dissect_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
{
gint len, offset=0, eoh=0;
guint8 avptype, avplen;
guint32 avpfound=0;
len=tvb_length(tvb);
if (len < MIN_REDBACKLI_SIZE)
@ -197,11 +198,13 @@ redbackli_dissect_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
case(RB_AVP_SESSID):
if (avplen != 4)
return FALSE;
avpfound|=1<<avptype;
break;
case(RB_AVP_LABEL):
avpfound|=1<<avptype;
break;
case(RB_AVP_EOH):
if (avplen > 1)
if (avplen > 1 || offset == 0)
return FALSE;
eoh=1;
break;
@ -212,6 +215,13 @@ redbackli_dissect_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
len-=2+avplen;
}
if (!(avpfound & (1<<RB_AVP_SEQNO)))
return FALSE;
if (!(avpfound & (1<<RB_AVP_SESSID)))
return FALSE;
if (!(avpfound & (1<<RB_AVP_LIID)))
return FALSE;
redbackli_dissect(tvb, pinfo, tree);
return TRUE;