From d4063f3caee59e009bc912c24b2514bdb517121c Mon Sep 17 00:00:00 2001 From: Alexis La Goutte Date: Thu, 21 Feb 2019 09:57:44 +0100 Subject: [PATCH] profinet: fix Control flow issues (DEADCODE) CID 1442818 & 1442815 Change-Id: I8e7201795a780f10923ff6fb0af6b78adc56b75d Reviewed-on: https://code.wireshark.org/review/32135 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Mehmet Oguz Sakaoglu Reviewed-by: Anders Broman --- plugins/epan/profinet/packet-pn-dcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/epan/profinet/packet-pn-dcp.c b/plugins/epan/profinet/packet-pn-dcp.c index 82f73cd730..5f7d7a4563 100644 --- a/plugins/epan/profinet/packet-pn-dcp.c +++ b/plugins/epan/profinet/packet-pn-dcp.c @@ -519,13 +519,14 @@ dissect_PNDCP_Suboption_IP(tvbuff_t *tvb, int offset, packet_info *pinfo, ((service_id == PNDCP_SERVICE_ID_HELLO) && !is_response) || ((service_id == PNDCP_SERVICE_ID_GET) && is_response)) { offset = dissect_pn_uint16(tvb, offset, pinfo, tree, hf_pn_dcp_block_info, &block_info); + have_block_info = TRUE; block_length -= 2; } /* BlockQualifier? */ if ((service_id == PNDCP_SERVICE_ID_SET) && !is_response) { offset = dissect_pn_uint16(tvb, offset, pinfo, tree, hf_pn_dcp_block_qualifier, &block_qualifier); - + have_block_qualifier = TRUE; block_length -= 2; }