From d248702b86ae8b3980840c8143c93ec144c62dd0 Mon Sep 17 00:00:00 2001 From: John Thacker Date: Sun, 16 Oct 2022 17:36:21 -0400 Subject: [PATCH] nbt: Eliminate clang analyzer warning By using strlcat later, we don't need to update pname_ret again, since we only need the total size of the buffer. Elminates a clang analyzer warning about writing a value that is never used related to commit 9891a791379e248f7de48e97448f38217fb7ff49 --- epan/dissectors/packet-nbt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/epan/dissectors/packet-nbt.c b/epan/dissectors/packet-nbt.c index f23c23f330..538f232846 100644 --- a/epan/dissectors/packet-nbt.c +++ b/epan/dissectors/packet-nbt.c @@ -400,8 +400,7 @@ get_nbns_name(tvbuff_t *tvb, int offset, int nbns_data_offset, /* This one is; make its name printable. */ name_type = process_netbios_name(nbname, name_ret, name_ret_len); pname_ret += MIN(strlen(name_ret), (size_t) name_ret_len); - pname_ret += MIN(name_ret_len-(pname_ret-name_ret), - snprintf(pname_ret, name_ret_len-(gulong)(pname_ret-name_ret), "<%02x>", name_type)); + snprintf(pname_ret, name_ret_len-(gulong)(pname_ret-name_ret), "<%02x>", name_type); if (cname == '.') { /* We have a scope ID, starting at "pname"; append that to * the decoded host name. */