osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

bthci: add a note about the case where we hve no connection handle. 

A previous change initialized the k_connection_handle, so we don't
compare random data with remote_bdaddr->chandle, but perhaps we
shouldn't compare it at all if we didn't find a handle pair.
This commit is contained in:
Guy Harris 2020-10-19 21:19:39 -07:00
parent 666e74401a
commit c8882c0f29
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
epan/dissectors/packet-bthci_iso.c
View File

@ -205,6 +205,10 @@ dissect_bthci_iso(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *dat
/* remote bdaddr and name */
remote_bdaddr = (remote_bdaddr_t *)wmem_tree_lookup32_array_le(bluetooth_data->chandle_to_bdaddr, key);
/*
* XXX - do this only if we found a handle pair, so that we have
* a connection handle?
*/
if (remote_bdaddr && remote_bdaddr->interface_id == bluetooth_data->interface_id &&
remote_bdaddr->adapter_id == bluetooth_data->adapter_id &&
remote_bdaddr->chandle == k_connection_handle) {