osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

signal-pdu: fix DeadStore found by Clang Analyzer 

packet-signal-pdu.c:2265:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
packet-signal-pdu.c:2268:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
packet-signal-pdu.c:2271:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
This commit is contained in:
Alexis La Goutte 2022-02-08 13:54:25 +00:00 committed by A Wireshark GitLab Utility
parent 3dee67b2a2
commit c115a2ae60
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
epan/dissectors/packet-signal-pdu.c
View File

@ -2262,13 +2262,13 @@ dissect_spdu_payload_signal(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
/* if frame data was not created on first pass, we cannot calculate it now */
if (spdu_frame_data != NULL) {
if (item->aggregate_sum) {
ti = proto_tree_add_double(subtree, *(item->hf_id_agg_sum), tvb, offset, signal_length, spdu_frame_data->sum);
proto_tree_add_double(subtree, *(item->hf_id_agg_sum), tvb, offset, signal_length, spdu_frame_data->sum);
}
if (item->aggregate_avg) {
ti = proto_tree_add_double(subtree, *(item->hf_id_agg_avg), tvb, offset, signal_length, spdu_frame_data->avg);
proto_tree_add_double(subtree, *(item->hf_id_agg_avg), tvb, offset, signal_length, spdu_frame_data->avg);
}
if (item->aggregate_int && (spdu_frame_data->sum_time_value_products == spdu_frame_data->sum_time_value_products)) {
ti = proto_tree_add_double(subtree, *(item->hf_id_agg_int), tvb, offset, signal_length, spdu_frame_data->sum_time_value_products);
proto_tree_add_double(subtree, *(item->hf_id_agg_int), tvb, offset, signal_length, spdu_frame_data->sum_time_value_products);
}
}
}