From ba16825c6c1284fd54c2f87eef240f1af655607c Mon Sep 17 00:00:00 2001
From: Martin Kaiser <wireshark@kaiser.cx>
Date: Sun, 6 Dec 2020 19:52:12 +0100
Subject: [PATCH] Qt: column list model: remove unused ListElement component

Selecting Edit / Preferences on my asan+ubsan build brings up the
following warning from ubsan:

/media/sf_wireshark.git/ui/qt/models/column_list_model.cpp:273:9:
runtime error: load of value 25, which is not a valid value for type 'bool'

The problem is in ColumnListModel::populate(), where a ListElement is
populated from fmt_data. The ListElement's "changed" component is not
initialized, though.

It looks like "changed" is not used anywhere. This patch removes it from
the ListElement struct.
---
 ui/qt/models/column_list_model.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui/qt/models/column_list_model.cpp b/ui/qt/models/column_list_model.cpp
index 9de1ba3d60..e973eae17c 100644
--- a/ui/qt/models/column_list_model.cpp
+++ b/ui/qt/models/column_list_model.cpp
@@ -33,7 +33,6 @@ struct ListElement
     int originalType;
     int occurrence;
     bool displayed;
-    bool changed;
 };
 
 static QList<ListElement> store_;