osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Qt: column list model: remove unused ListElement component 

Selecting Edit / Preferences on my asan+ubsan build brings up the
following warning from ubsan:

/media/sf_wireshark.git/ui/qt/models/column_list_model.cpp:273:9:
runtime error: load of value 25, which is not a valid value for type 'bool'

The problem is in ColumnListModel::populate(), where a ListElement is
populated from fmt_data. The ListElement's "changed" component is not
initialized, though.

It looks like "changed" is not used anywhere. This patch removes it from
the ListElement struct.
This commit is contained in:
Martin Kaiser 2020-12-06 19:52:12 +01:00 committed by AndersBroman
parent a16c1697dc
commit ba16825c6c
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ui/qt/models/column_list_model.cpp
View File

@ -33,7 +33,6 @@ struct ListElement
int originalType;
int occurrence;
bool displayed;
bool changed;
};
static QList<ListElement> store_;