osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

RTP dialogs fix: sigv occurs when dialogs are open when no cap file is open 

Patch fixes the issue which causes sigv fault when user tries to open
VoIP Analysis or RTP Streams dialog and no capture file is open.
This commit is contained in:
Jirka Novak 2021-01-03 08:22:33 +01:00
parent a256ad68d6
commit b9e5b58ee9
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/qt/rtp_stream_dialog.cpp
View File

@ -301,7 +301,7 @@ RtpStreamDialog::RtpStreamDialog(QWidget &parent, CaptureFile &cf) :
tapinfo_.mode = TAP_ANALYSE;
register_tap_listener_rtpstream(&tapinfo_, NULL, show_tap_registration_error);
if (cap_file_.capFile()->dfilter) {
if (cap_file_.isValid() && cap_file_.capFile()->dfilter) {
// Activate display filter checking
tapinfo_.apply_display_filter = true;
ui->displayFilterCheckBox->setChecked(true);

2
ui/qt/voip_calls_dialog.cpp
View File

@ -96,7 +96,7 @@ VoipCallsDialog::VoipCallsDialog(QWidget &parent, CaptureFile &cf, bool all_flow
shown_callsinfos_ = g_queue_new();
voip_calls_init_all_taps(&tapinfo_);
if (cap_file_.capFile()->dfilter) {
if (cap_file_.isValid() && cap_file_.capFile()->dfilter) {
// Activate display filter checking
tapinfo_.apply_display_filter = true;
ui->displayFilterCheckBox->setChecked(true);