Overhaul AMQP dissector

Browse Source

1. Remove AMQP_INCREMENT macro.  Bounds checking mostly handled already
by proto_tree_add_xxx and tvb_get_xxx.  Needed to add a few more
tvb_reported_length_remaining() calls for completeness.
2. Fill in some of the gaps of unaccounted for bytes.  Still have way
too many instances where bytes aren't claimed by a field.
3. Some small reordering of functions allowed for massive removal of
formal declarations.
4. Add amqp_0_10_get_32bit_size_new to add a field, check for size and
add expert info if size > 0xFFFF
5. Remove "hf_" from list type items as they are not real hf_ fields
and could cause confusion.  Also made items static.
6. Convert some FT_STRING and FT_BYTES fields to FT_UINT_STRING and
FT_UINT_BYTES.  Helps account for some "missing" bytes.

Change-Id: I7ed269221d294ce89feacc0642b2070681288172
Reviewed-on: https://code.wireshark.org/review/18423
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>

...

This commit is contained in:

Michael Mann 2016-10-22 14:25:35 -04:00 committed by Roland Knall

parent e3ecb9310c

commit b5587379b7

1 changed files with 2039 additions and 2672 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4711

epan/dissectors/packet-amqp.c

View File

File diff suppressed because it is too large Load Diff