osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

tap-sctp: remove leak of sack and tsn (found by clang). 

Change-Id: I829f117f8e19f60d34104730fbb0bc4504f231dd
Reviewed-on: https://code.wireshark.org/review/26434
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Dario Lombardo 2018-03-10 23:36:38 +01:00 committed by Anders Broman
parent f96abc7fc0
commit b19ca06fcc
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ui/tap-sctp-analysis.c
View File

@ -1105,7 +1105,6 @@ packet(void *tapdata _U_, packet_info *pinfo, epan_dissect_t *edt _U_, const voi
g_ptr_array_add(info->sort_sack2, tsn_s);
info->n_sack_chunks_ep2++;
}
}
}
}
@ -1120,6 +1119,10 @@ packet(void *tapdata _U_, packet_info *pinfo, epan_dissect_t *edt _U_, const voi
else if (info->direction == 2)
info->tsn2 = g_list_prepend(info->tsn2, tsn);
}
else
{
g_free(tsn);
}
if (sackchunk == TRUE)
{
if (info->direction == 1)
@ -1127,6 +1130,10 @@ packet(void *tapdata _U_, packet_info *pinfo, epan_dissect_t *edt _U_, const voi
else if(info->direction == 2)
info->sack1 = g_list_prepend(info->sack1, sack);
}
else
{
g_free(sack);
}
info->n_tvbs += sctp_info->number_of_tvbs;
sctp_tapinfo_struct.sum_tvbs += sctp_info->number_of_tvbs;
info = calc_checksum(sctp_info, info);