osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

BACAPP: fix dissection of event parameters for event notifications of Event_Type Change_of_Characterstring 

Implementation for this event parameter type was missing

Bug: 9625
Change-Id: I575d387ec4764fa1ecd365624d13e3f41e2473c6
Reviewed-on: https://code.wireshark.org/review/5189
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
This commit is contained in:
desolat 2014-11-08 13:05:03 +01:00 committed by Evan Huus
parent 79d3c33c17
commit ae61a41e57
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
epan/dissectors/packet-bacapp.c
View File

@ -8067,6 +8067,27 @@ fNotificationParameters(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, gui
}
break;
case 17: /* change-of-characterstring */
while (tvb_reported_length_remaining(tvb, offset) > 0) { /* exit loop if nothing happens inside */
lastoffset = offset;
switch (fTagNo(tvb, offset)) {
case 0:
/* changed-value (CharacterString) */
offset = fCharacterString(tvb, pinfo, subtree, offset, "changed-value: ");
break;
case 1:
offset = fBitStringTagVS(tvb, pinfo, subtree, offset,
"status-flags: ", BACnetStatusFlags);
break;
case 2:
/* alarm-value (CharacterString) */
offset = fCharacterString(tvb, pinfo, subtree, offset, "alarm-value: ");
lastoffset = offset;
break;
default:
break;
}
if (offset == lastoffset) break; /* nothing happened, exit loop */
}
break;
case 18: /* change-of-status-flags */
break;