From ab977a86d0d4185900f212dabea75ba527d25dd1 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Tue, 9 Feb 2016 13:17:18 -0800 Subject: [PATCH] Properly check the return value of color_filters_set_tmp(). It returns FALSE, not TRUE, on failure. Bug: 12101 Change-Id: I2fb4f407d2040e7b84f17af197de81555d64c647 Reviewed-on: https://code.wireshark.org/review/13857 Reviewed-by: Guy Harris --- ui/qt/main_window_slots.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/qt/main_window_slots.cpp b/ui/qt/main_window_slots.cpp index 1069fa9427..0c163f7de8 100644 --- a/ui/qt/main_window_slots.cpp +++ b/ui/qt/main_window_slots.cpp @@ -2390,7 +2390,7 @@ void MainWindow::colorizeWithFilter() if (ok) { // Assume "Color X" gchar *err_msg = NULL; - if (color_filters_set_tmp(color_number, filter.toUtf8().constData(), FALSE, &err_msg)) { + if (!color_filters_set_tmp(color_number, filter.toUtf8().constData(), FALSE, &err_msg)) { simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "%s", err_msg); g_free(err_msg); }