From a88d60509d1f80f7d8a206a64aa7084312b2f82e Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Sun, 30 Dec 2018 23:47:09 -0800 Subject: [PATCH] Update the comment again. The third URL works, but let's go https: for it. The other two don't. Line-wrap another part of the comment while we're at it. Change-Id: I744770c859b317ace2a71e82f86e2419b6d7ef2b Reviewed-on: https://code.wireshark.org/review/31276 Reviewed-by: Guy Harris --- ui/win32/console_win32.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/ui/win32/console_win32.c b/ui/win32/console_win32.c index b0dffc1f68..edaa95286f 100644 --- a/ui/win32/console_win32.c +++ b/ui/win32/console_win32.c @@ -147,17 +147,23 @@ create_console(void) http://msdn.microsoft.com/en-us/library/windows/desktop/ms681952(v=vs.85).aspx -and according to + (which now redirects to a docs.microsoft.com page that is + devoid of comments, and which is not available on the + Wayback Machine) + + and according to http://connect.microsoft.com/VisualStudio/feedback/details/689696/installing-security-update-kb2507938-prevents-console-allocation -and + (which has disappeared, and isn't available on the Wayback + Machine) -http://answers.microsoft.com/en-us/windows/forum/windows_xp-windows_update/kb2567680-andor-kb2507938-breaks-attachconsole-api/e8191280-2d49-4be4-9918-18486fba0afa + and -(none of which are available any more, either at any obvious Microsoft site or -on the Wayback Machine), even a failed attempt to attach to another process's -console will cause subsequent AllocConsole() calls to fail, possibly due +https://answers.microsoft.com/en-us/windows/forum/windows_xp-windows_update/kb2567680-andor-kb2507938-breaks-attachconsole-api/e8191280-2d49-4be4-9918-18486fba0afa + +even a failed attempt to attach to another process's console +will cause subsequent AllocConsole() calls to fail, possibly due to bugs introduced by a security patch. To work around this, we do a FreeConsole() first. */ FreeConsole();