From a3f9c6bc4575d6f56b3248638cb629482ec76e1e Mon Sep 17 00:00:00 2001 From: Alexis La Goutte Date: Tue, 27 Jul 2021 12:46:07 +0000 Subject: [PATCH] erf: Fix Dead Store (found by Clang Anlyzer) Although the value stored to 'tagtotallength' is used in the enclosing expression, the value is never actually read from 'tagtotallength' --- wiretap/erf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wiretap/erf.c b/wiretap/erf.c index d04bda82fb..aedbafe094 100644 --- a/wiretap/erf.c +++ b/wiretap/erf.c @@ -3351,7 +3351,7 @@ static int populate_summary_info(erf_t *erf_priv, wtap *wth, union wtap_pseudo_h state.tag_ptr += tagtotallength; state.remaining_len -= tagtotallength; - if ((tagtotallength = erf_meta_read_tag(&tag, state.tag_ptr, state.remaining_len))) { + if (erf_meta_read_tag(&tag, state.tag_ptr, state.remaining_len)) { /* * Process parent section tag if present (which must be the first tag in * the section).