osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Don't roll your own code for showing the usual display of bits in a 

bitfield, use the code we already have.

svn path=/trunk/; revision=16284
This commit is contained in:
Guy Harris 2005-10-22 03:52:06 +00:00
parent 097f75dd7a
commit a24b71271a
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
epan/dissectors/packet-iapp.c
View File

@ -184,27 +184,22 @@ static value_string iapp_auth_type_vals[] = {
static void dissect_caps(proto_item *pitem, tvbuff_t *tvb, int offset)
{
proto_tree *captree;
int bit, val, z, thisbit;
int bit, val, thisbit;
const gchar *strval;
gchar bitval[20];
gchar bitval[4+1+4+1]; /* "xxxx xxxx\0" */
captree = proto_item_add_subtree(pitem, ett_iapp_cap);
val = tvb_get_guint8(tvb, offset + 3);
bitval[8] = '\0';
for (bit = 7; bit >= 0; bit--)
{
strval = match_strval(1 << bit, iapp_cap_vals);
thisbit = 1 << bit;
strval = match_strval(thisbit, iapp_cap_vals);
if (strval)
{
thisbit = (val & (1 << bit)) ? 1 : 0;
for (z = 0; z < 7; z++)
if (z == 7 - bit)
bitval[z] = thisbit + '0';
else
bitval[z] = '.';
other_decode_bitfield_value(bitval, val, thisbit, 8);
proto_tree_add_text(captree, tvb, offset + 3, 1, "%s %s: %s",
bitval, strval, thisbit ? "Yes" : "No");
bitval, strval, val & thisbit ? "Yes" : "No");
}
}
}