osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

GOOSE: add back goose.floating_point filter 

Let's add it as a hidden filter for IEEE 754 single precision floating point

Closes #18491
This commit is contained in:
Pascal Quantin 2022-11-01 14:02:43 +00:00
parent fd7716542c
commit a1c55f2356
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
epan/dissectors/asn1/goose/goose.cnf
View File

@ -68,12 +68,11 @@ GOOSEpdu
int len = tvb_reported_length_remaining(tvb, offset);
%(DEFAULT_BODY)s
if ((len == FLOAT_ENC_LENGTH) && (tvb_get_guint8(tvb,0) == SINGLE_FLOAT_EXP_BITS) ){
/* IEEE 754 single precision floating point */
proto_item_set_hidden(actx->created_item);
proto_tree_add_item(tree, hf_goose_float_value, tvb, 1, (FLOAT_ENC_LENGTH-1), ENC_BIG_ENDIAN);
offset = len;
}else{
%(DEFAULT_BODY)s
}
#.END

11
epan/dissectors/packet-goose.c
View File

@ -626,14 +626,13 @@ dissect_goose_FloatingPoint(gboolean implicit_tag _U_, tvbuff_t *tvb _U_, int of
int len = tvb_reported_length_remaining(tvb, offset);
if ((len == FLOAT_ENC_LENGTH) && (tvb_get_guint8(tvb,0) == SINGLE_FLOAT_EXP_BITS) ){
/* IEEE 754 single precision floating point */
proto_tree_add_item(tree, hf_goose_float_value, tvb, 1, (FLOAT_ENC_LENGTH-1), ENC_BIG_ENDIAN);
offset = len;
}else{
offset = dissect_ber_octet_string(implicit_tag, actx, tree, tvb, offset, hf_index,
offset = dissect_ber_octet_string(implicit_tag, actx, tree, tvb, offset, hf_index,
NULL);
if ((len == FLOAT_ENC_LENGTH) && (tvb_get_guint8(tvb,0) == SINGLE_FLOAT_EXP_BITS) ){
/* IEEE 754 single precision floating point */
proto_item_set_hidden(actx->created_item);
proto_tree_add_item(tree, hf_goose_float_value, tvb, 1, (FLOAT_ENC_LENGTH-1), ENC_BIG_ENDIAN);
}