From 945d441b2484f901f1c0c3696bf4cdec4838cb40 Mon Sep 17 00:00:00 2001 From: Dario Lombardo Date: Sun, 4 Nov 2018 00:02:07 +0100 Subject: [PATCH] extcap: fix return value in extcap_base_parse_options(). We need to split good options' from bad options' return value. Change-Id: I836e58c0f05716484664f354e7332a74d6a08c20 Reviewed-on: https://code.wireshark.org/review/30503 Reviewed-by: Dario Lombardo Petri-Dish: Dario Lombardo Tested-by: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman --- extcap/extcap-base.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/extcap/extcap-base.c b/extcap/extcap-base.c index bf34d39326..4a1cc03e84 100644 --- a/extcap/extcap-base.c +++ b/extcap/extcap-base.c @@ -108,6 +108,8 @@ static void extcap_custom_log(const gchar *log_domain, uint8_t extcap_base_parse_options(extcap_parameters * extcap, int result, char * optargument) { + uint8_t ret = 1; + switch (result) { case EXTCAP_OPT_DEBUG: #ifdef _WIN32 @@ -145,9 +147,11 @@ uint8_t extcap_base_parse_options(extcap_parameters * extcap, int result, char * case EXTCAP_OPT_FIFO: extcap->fifo = g_strdup(optargument); break; + default: + ret = 0; } - return 1; + return ret; } static void extcap_iface_print(gpointer data, gpointer userdata _U_)