osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Qt: Speed up filtering in VoIP dialog 

Speed up the filtering, by only taking rows once

Change-Id: I6123b2974fd58480463e4a0bd02524f6b5c0a353
Reviewed-on: https://code.wireshark.org/review/34879
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
This commit is contained in:
Roland Knall 2019-10-28 17:07:14 +01:00
parent 541afedfbc
commit 8d62cc3aea
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ui/qt/voip_calls_dialog.cpp
View File

@ -253,14 +253,20 @@ void VoipCallsDialog::prepareFilter()
QString filter_str;
QSet<guint16> selected_calls;
QString frame_numbers;
QList<int> rows;
/* Build a new filter based on frame numbers */
foreach (QModelIndex index, ui->callTreeView->selectionModel()->selectedIndexes()) {
voip_calls_info_t *call_info = VoipCallsInfoModel::indexToCallInfo(index);
if (!call_info) {
return;
if ( index.isValid() && ! rows.contains(index.row()) )
{
voip_calls_info_t *call_info = VoipCallsInfoModel::indexToCallInfo(index);
if (!call_info) {
return;
}
selected_calls << call_info->call_num;
rows << index.row();
}
selected_calls << call_info->call_num;
}
GList *cur_ga_item = g_queue_peek_nth_link(tapinfo_.graph_analysis->items, 0);