osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Make some routines static. 

Change-Id: I04860f058345cb633ab379c83dcfc24b6cf1a846
Reviewed-on: https://code.wireshark.org/review/20797
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This commit is contained in:
Guy Harris 2017-03-30 12:39:29 -07:00
parent 1c3d85d577
commit 8bf0a57ce1
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-arp.c
View File

@ -564,7 +564,7 @@ static const value_string atm_nsap_afi_vals[] = {
/*
* XXX - shouldn't there be a centralized routine for dissecting NSAPs?
* See also "dissect_nsap()" in epan/dissectors/packet-isup.c and
* "print_nsap_net_buf()" and "print_nsap_net()" in epan/osi=utils.c.
* "print_nsap_net()" in epan/osi=utils.c.
*/
void
dissect_atm_nsap(tvbuff_t *tvb, packet_info* pinfo, int offset, int len, proto_tree *tree)

2
epan/dissectors/packet-isup.c
View File

@ -4148,7 +4148,7 @@ static const value_string iana_icp_values[] = {
/*
* XXX - shouldn't there be a centralized routine for dissecting NSAPs?
* See also "dissect_atm_nsap()" in epan/dissectors/packet-arp.c and
* "print_nsap_net_buf()" and "print_nsap_net()" in epan/osi_utils.c.
* "print_nsap_net()" in epan/osi_utils.c.
*/
void
dissect_nsap(tvbuff_t *parameter_tvb, gint offset, gint len, proto_tree *parameter_tree)

8
epan/osi-utils.c
View File

@ -35,6 +35,9 @@
#include "address.h"
#include "address_types.h"
static void print_nsap_net_buf( const guint8 *, int, gchar *, int);
static void print_area_buf ( const guint8 *, int, gchar *, int);
/*
* XXX - shouldn't there be a centralized routine for dissecting NSAPs?
* See also "dissect_atm_nsap()" in epan/dissectors/packet-arp.c and
@ -50,8 +53,7 @@ print_nsap_net( tvbuff_t *tvb, const gint offset, int length )
return( cur );
}
/* XXX - Should these be converted to string buffers? */
void
static void
print_nsap_net_buf( const guint8 *ad, int length, gchar *buf, int buf_len)
{
gchar *cur;
@ -150,7 +152,7 @@ print_area(tvbuff_t *tvb, const gint offset, int length)
return cur;
}
void
static void
print_area_buf(const guint8 *ad, int length, gchar *buf, int buf_len)
{
gchar *cur;

2
epan/osi-utils.h
View File

@ -46,9 +46,7 @@
#define NSAP_IDI_GOSIP2 0x47
gchar* print_nsap_net ( tvbuff_t *, const gint, int );
void print_nsap_net_buf( const guint8 *, int, gchar *, int);
gchar* print_area ( tvbuff_t *, const gint, int );
void print_area_buf ( const guint8 *, int, gchar *, int);
gchar* print_system_id(wmem_allocator_t *, const guint8 *, int );
gchar* tvb_print_system_id( tvbuff_t *, const gint, int );
void print_system_id_buf( const guint8 *, int, gchar *, int);