osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

LteMacStatisticsDialog: fix memory leaks 

Remember the delegates that we use and free them explicitly
in the destructor.

Change-Id: Iba07c3e9952dc152d94468b6b7c7e2c2a74c1f65
Reviewed-on: https://code.wireshark.org/review/36965
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Martin Kaiser 2020-04-27 22:46:02 +02:00 committed by Anders Broman
parent 8025250313
commit 7bd3f8a58f
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ui/qt/lte_mac_statistics_dialog.cpp
View File

@ -536,8 +536,10 @@ LteMacStatisticsDialog::LteMacStatisticsDialog(QWidget &parent, CaptureFile &cf,
// Will set whole-UE headings originally.
updateHeaderLabels();
statsTreeWidget()->setItemDelegateForColumn(col_ul_padding_percent_, new PercentBarDelegate());
statsTreeWidget()->setItemDelegateForColumn(col_dl_padding_percent_, new PercentBarDelegate());
ul_delegate_ = new PercentBarDelegate();
statsTreeWidget()->setItemDelegateForColumn(col_ul_padding_percent_, ul_delegate_);
dl_delegate_ = new PercentBarDelegate();
statsTreeWidget()->setItemDelegateForColumn(col_dl_padding_percent_, dl_delegate_);
statsTreeWidget()->sortByColumn(col_rnti_, Qt::AscendingOrder);
@ -608,6 +610,8 @@ LteMacStatisticsDialog::LteMacStatisticsDialog(QWidget &parent, CaptureFile &cf,
// Destructor.
LteMacStatisticsDialog::~LteMacStatisticsDialog()
{
delete ul_delegate_;
delete dl_delegate_;
}
// Update system/common counters, and redraw if changed.

2
ui/qt/lte_mac_statistics_dialog.h
View File

@ -15,6 +15,7 @@
#include <QLabel>
#include <QCheckBox>
#include <ui/qt/models/percent_bar_delegate.h>
// Common channel stats
typedef struct mac_lte_common_stats {
@ -48,6 +49,7 @@ private:
QLabel *commonStatsLabel_;
QCheckBox *showSRFilterCheckBox_;
QCheckBox *showRACHFilterCheckBox_;
PercentBarDelegate *ul_delegate_, *dl_delegate_;
QString displayFilter_;
// Callbacks for register_tap_listener