osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

1. Fix bug in dissection of a field; Add two missing lines of code. 

2. #if 0 if test "which will never be true"; Add XXX comment

svn path=/trunk/; revision=36369
This commit is contained in:
Bill Meier 2011-03-27 15:39:06 +00:00
parent a4f03a1101
commit 7a77cdf0f1
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
epan/dissectors/packet-q933.c
View File

@ -581,6 +581,8 @@ dissect_q933_bearer_capability_ie(tvbuff_t *tvb, int offset, int len,
"Parity: %s",
val_to_str(octet & 0x07, q933_l1_parity_vals,
"Unknown (0x%X)"));
offset += 1;
len -= 1;
if (octet & Q933_IE_VL_EXTENSION)
goto l1_done;
@ -707,8 +709,10 @@ l2_done:
add_l3_info = (octet & 0x0F) << 4;
if (octet & Q933_IE_VL_EXTENSION)
goto l3_done;
#if 0 /* XXX: len is always >0 at this point; is field always 2 bytes (if not Q933_IE_VL_EXTENSION) ? */
if (len == 0)
return;
#endif
octet = tvb_get_guint8(tvb, offset + 1);
add_l3_info |= (octet & 0x0F);
proto_tree_add_text(tree, tvb, offset, 2,