osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

TECMP: Fixing the dissection of Status Bus Vendor Ext 

Link Status, Link Quality, and Linkup Time all use the same byte
due to a wrong offset. This patch is a fix for this bug.

Bug: 16738
Change-Id: I7e6eec5665e7df46446e0a729954bc531d28c42d
Reviewed-on: https://code.wireshark.org/review/37977
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
This commit is contained in:
Dr. Lars Völker 2020-07-28 13:16:17 +02:00 committed by Alexis La Goutte
parent 21e0037231
commit 7760bcb3dc
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
epan/dissectors/packet-tecmp.c
View File

@ -2,6 +2,7 @@
* Technically Enhanced Capture Module Protocol (TECMP) dissector.
* By <lars.voelker@technica-engineering.de>
* Copyright 2019-2020 Dr. Lars Voelker
* Copyright 2020 Ayoub Kaanich
*
* Wireshark - Network traffic analyzer
* By Gerald Combs <gerald@wireshark.org>
@ -723,14 +724,16 @@ dissect_tecmp_status_bus_vendor_data(tvbuff_t *tvb, packet_info *pinfo _U_, prot
if (bytes_remaining >= 1) {
proto_tree_add_item(tree, hf_tecmp_payload_status_bus_vendor_technica_link_status, tvb, offset, 1, ENC_NA);
offset += 1;
}
if (bytes_remaining >= 2) {
proto_tree_add_item(tree, hf_tecmp_payload_status_bus_vendor_technica_link_quality, tvb, offset, 1,
ENC_NA);
offset += 1;
}
if (bytes_remaining >= 4) {
ti = proto_tree_add_item_ret_uint(tree, hf_tecmp_payload_status_bus_vendor_technica_linkup_time, tvb,
offset, 1, ENC_NA, &tmp);
offset, 2, ENC_NA, &tmp);
if (tmp==0) {
proto_item_append_text(ti, " %s", "(no linkup detected yet)");
} else if (tmp == 0xffff) {