osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

BACAPP: fix dissection of event parameters for event notifications of Event_Type Change_of_Status_Flags 

Implementation for this event parameter type was missing

Bug: 9626
Change-Id: Iea0bc819858bbf5660d97cfd0c418a963ac149fb
Reviewed-on: https://code.wireshark.org/review/5228
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
desolat 2014-11-11 00:46:05 +01:00 committed by Anders Broman
parent b2c2debd97
commit 7469faba5e
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
epan/dissectors/packet-bacapp.c
View File

@ -8090,6 +8090,26 @@ fNotificationParameters(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, gui
}
break;
case 18: /* change-of-status-flags */
while (tvb_reported_length_remaining(tvb, offset) > 0) {
/* exit loop if nothing happens inside */
lastoffset = offset;
switch (fTagNo(tvb, offset)) {
case 0:
offset += fTagHeaderTree(tvb, pinfo, subtree, offset, &tag_no, &tag_info, &lvt);
offset = fApplicationTypesEnumerated(tvb, pinfo, subtree, offset,
"present-value: ", BACnetStatusFlags);
offset += fTagHeaderTree(tvb, pinfo, subtree, offset, &tag_no, &tag_info, &lvt);
break;
case 1:
offset = fBitStringTagVS(tvb, pinfo, subtree, offset,
"referenced-flags: ", BACnetStatusFlags);
lastoffset = offset;
break;
default:
break;
}
if (offset == lastoffset) break; /* nothing happened, exit loop */
}
break;
/* todo: add new parameters here ... */
default: