osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

GVSP: enforce heuristic (get some false positive with STUN) 

Change-Id: Ic1da51a71ee4fa60267751d7bb3f46225ad2f084
Reviewed-on: https://code.wireshark.org/review/16573
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Alexis La Goutte 2016-07-21 23:27:05 +02:00 committed by Anders Broman
parent d3ce757de0
commit 6fbaf9be34
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
epan/dissectors/packet-gvsp.c
View File

@ -1404,6 +1404,16 @@ static gboolean dissect_gvsp_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree
/* Check for valid format types */
if (format >= 1 && format <= 6)
{
if(format == GVSP_PACKET_LEADER && tvb_captured_length_remaining(tvb, 8) >= 2)
{
guint32 payloadtype;
payloadtype = tvb_get_ntohs(tvb, 8);
payloadtype &= 0x3FFF;
if (try_val_to_str_ext(payloadtype, &payloadtypenames_ext) == NULL ){
return FALSE;
}
}
conversation = find_or_create_conversation(pinfo);
conversation_set_dissector(conversation, gvsp_handle);
dissect_gvsp(tvb, pinfo, tree, data);