From 6b9beb6ca16374aa768fd965d26edce41ecbf1a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Valverde?= Date: Tue, 21 Aug 2018 23:44:12 +0100 Subject: [PATCH] Fix comment. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: Ib41b9a84333a3d3d34ae9c0797dbae10141f9e53 Reviewed-on: https://code.wireshark.org/review/29235 Reviewed-by: João Valverde --- doc/plugins.example/CMakeLists.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/plugins.example/CMakeLists.txt b/doc/plugins.example/CMakeLists.txt index d754fc4cf3..23a7e8f713 100644 --- a/doc/plugins.example/CMakeLists.txt +++ b/doc/plugins.example/CMakeLists.txt @@ -17,9 +17,8 @@ find_package(PkgConfig REQUIRED) pkg_check_modules(WIRESHARK REQUIRED wireshark>=2.5) ### CMake Bug: Use PKG_CONFIG_PATH instead of CMAKE_PREFIX_PATH # https://gitlab.kitware.com/cmake/cmake/issues/15805 -### CMake Bug: If you run into problems please use the "Unix Makefiles" generator. -### Ninja just wipes the pkg-config variables. -# https://gitlab.kitware.com/cmake/cmake/issues/17531 (and probably others) +# Note: If using PKG_CONFIG_PATH the variable needs to be set as exported +# in the execution environment. pkg_get_variable(WIRESHARK_PLUGIN_DIR wireshark plugindir) set(PLUGIN_INSTALL_LIBDIR "${WIRESHARK_PLUGIN_DIR}/epan")