osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Optimize proto_item_append_string() 

- When old string empty just pass new one (like: frame.protocols)
- if not, use ep_strconcat()

svn path=/trunk/; revision=50890
This commit is contained in:
Jakub Zawadzki 2013-07-25 17:19:17 +00:00
parent 35e220513c
commit 696a79707b
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
epan/proto.c
View File

@ -2558,7 +2558,7 @@ proto_item_append_string(proto_item *pi, const char *str)
{
field_info *fi;
header_field_info *hfinfo;
gchar *old_str, *new_str;
const gchar *old_str, *new_str;
if (!pi)
return;
@ -2575,8 +2575,11 @@ proto_item_append_string(proto_item *pi, const char *str)
}
DISSECTOR_ASSERT(hfinfo->type == FT_STRING || hfinfo->type == FT_STRINGZ);
old_str = (guint8 *)fvalue_get(&fi->value);
new_str = ep_strdup_printf("%s%s", old_str, str);
fvalue_set(&fi->value, new_str, FALSE);
if (old_str && old_str[0])
new_str = ep_strconcat(old_str, str, NULL);
else
new_str = str;
fvalue_set(&fi->value, (gpointer) new_str, FALSE);
}
/* Set the FT_STRING value */