From 66fc2d4ee3aac5c7894e3150263d5aab716646f7 Mon Sep 17 00:00:00 2001 From: John Thacker Date: Tue, 7 Feb 2023 18:20:50 -0500 Subject: [PATCH] Qt: Actually ensure that rows are colorized PacketListRecords should only report themselves as colorized when colorized with the latest version of the coloring rules. Otherwise, ensureRowColorized will not recolorize rows when the rules have changed. This makes the minimap/intelligent scrollbar correctly update colors in the background when the rules have changed. (Rows that were being displayed were being updated, because the columnStrings were invalidated at the same time, and when fetching the columnStrings the colors would be updated if the rules had changed.) Fix #17621 --- ui/qt/models/packet_list_record.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/qt/models/packet_list_record.h b/ui/qt/models/packet_list_record.h index 2a6db75cba..20399f3d87 100644 --- a/ui/qt/models/packet_list_record.h +++ b/ui/qt/models/packet_list_record.h @@ -40,7 +40,7 @@ public: frame_data *frameData() const { return fdata_; } // packet_list->col_to_text in gtk/packet_list_store.c static int textColumn(int column) { return cinfo_column_.value(column, -1); } - bool colorized() { return colorized_; } + bool colorized() { return colorized_ && (color_ver_ == rows_color_ver_); } unsigned int conversation() { return conv_index_; } int columnTextSize(const char *str);