osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

extcap: Fix Coverity 1559270 

Check to see if the return pointer is non NULL
This commit is contained in:
John Thacker 2023-12-16 10:12:48 -05:00
parent 636f0a989a
commit 63840f1cfb
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
extcap.c
View File

@ -566,7 +566,7 @@ static gboolean cb_dlt(extcap_callback_info_t cb_info)
}
/* Check to see if we built a list */
if (linktype_list != NULL && cb_info.data != NULL)
if (linktype_list != NULL)
{
caps->data_link_types = linktype_list;
}
@ -579,7 +579,20 @@ static gboolean cb_dlt(extcap_callback_info_t cb_info)
*(cb_info.err_str) = g_strdup(caps->primary_msg);
}
}
*(if_capabilities_t **) cb_info.data = caps;
if (cb_info.data != NULL)
{
*(if_capabilities_t **) cb_info.data = caps;
} else
{
#ifdef HAVE_LIBPCAP
free_if_capabilities(caps);
#else
/* TODO: free_if_capabilities is in capture-pcap-util.c and doesn't
* get defined unless HAVE_LIBPCAP is set.
*/
g_free(caps);
#endif
}
extcap_free_dlts(temp);