osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

sparkplug: fix crash. 

The crash occurs when we don't have enough data to perform a string
comparison. Fix by first check it.
This commit is contained in:
Dario Lombardo 2021-05-17 13:51:41 +02:00 committed by Wireshark GitLab Utility
parent 8f8453bb12
commit 5eb6b85a7a
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
epan/dissectors/packet-sparkplug.c
View File

@ -58,11 +58,14 @@ dissect_sparkplugb(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *da
gchar **topic_elements, **current_element;
char *topic = (char *)data;
if (topic == NULL)
return FALSE;
/* Parse the topic into the elements */
topic_elements = g_strsplit(topic, "/", 5);
/* Heuristic check that the first element of the topic is the SparkplugB namespace */
if (!topic_elements || (strcmp("spBv1.0", topic_elements[0]) != 0)) {
if (!topic_elements || (g_strcmp0("spBv1.0", topic_elements[0]) != 0)) {
g_strfreev(topic_elements);
return FALSE;
}