osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

nfs: Fix order of octets in IPv4 address 

Before:

skull:bugs loghyr$ ~/ipv4/wireshark/tshark -r 2-layoutstats-in-1-compound.pcap -Y nfs -V | grep -i ipv4
                [IPv4 address 113.12.31.172, protocol=tcp, port=2049]

After:

skull:bugs loghyr$ ~/ipv4/wireshark/tshark -r 2-layoutstats-in-1-compound.pcap -Y nfs -V | grep -i ipv4
                [IPv4 address 172.31.12.113, protocol=tcp, port=2049]

Bug: 11496
Change-Id: Ia6097ae76411f6ff9de1f53191c8fc767856e2d1
Signed-off-by: Tom Haynes <loghyr@primarydata.com>
Reviewed-on: https://code.wireshark.org/review/10347
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
This commit is contained in:
Tom Haynes 2015-09-01 14:07:30 -07:00 committed by Pascal Quantin
parent 920e056bb4
commit 5d8363e83d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-nfs.c
View File

@ -7260,7 +7260,7 @@ dissect_nfs4_clientaddr(tvbuff_t *tvb, int offset, proto_tree *tree)
&b1, &b2, &b3, &b4, &b5, &b6) == 6) {
/* IPv4: h1.h2.h3.h4.p1.p2 */
port = (b5<<8) | b6;
ipv4 = (b1<<24) | (b2<<16) | (b3<<8) | b4;
ipv4 = g_htonl((b1<<24) | (b2<<16) | (b3<<8) | b4);
SET_ADDRESS(&addr, AT_IPv4, 4, &ipv4);
ti = proto_tree_add_ipv4_format(tree, hf_nfs4_universal_address_ipv4, tvb, addr_offset, offset-addr_offset, ipv4, "IPv4 address %s, protocol=%s, port=%u",
address_to_str(wmem_packet_scope(), &addr), protocol, port);