osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

docsis: fixed crash caused by absence of NULL termination of bitmask_list 

Change-Id: I41f86330366d939a12d0d70c63fe20e2220b8988
Reviewed-on: https://code.wireshark.org/review/30038
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Andrii Vladyka 2018-10-05 22:44:13 -07:00 committed by Anders Broman
parent af392b873a
commit 4a818a8569
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
epan/dissectors/packet-docsis-macmgmt.c
View File

@ -2923,7 +2923,8 @@ dissect_any_ucd (tvbuff_t * tvb, packet_info * pinfo, proto_tree * tree, int pro
static const int* timestamp_snapshot_parts[] = {
&hf_docsis_ucd_ofdma_timestamp_snapshot_reserved,
&hf_docsis_ucd_ofdma_timestamp_snapshot_d30timestamp,
&hf_docsis_ucd_ofdma_timestamp_snapshot_4msbits_of_div20
&hf_docsis_ucd_ofdma_timestamp_snapshot_4msbits_of_div20,
NULL
};
proto_tree_add_item (tlv_tree, hf_docsis_ucd_ofdma_timestamp_snapshot, tvb, pos, length, ENC_NA);
proto_tree_add_bitmask_list(tlv_tree, tvb, pos, 5, timestamp_snapshot_parts, ENC_BIG_ENDIAN);