osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

SDP: do not assume that media_desc pointer is always set 

Bug: 14648
Change-Id: I9d585a1b49e15529b19414be52c8bf198475fd62
Reviewed-on: https://code.wireshark.org/review/27304
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Pascal Quantin 2018-05-03 14:20:26 +02:00 committed by Anders Broman
parent faf5f86e7e
commit 47bf21a6c8
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
epan/dissectors/packet-sdp.c
View File

@ -2036,11 +2036,15 @@ static void dissect_sdp_media_attribute(tvbuff_t *tvb, packet_info *pinfo, proto
tvb, offset, -1, ENC_UTF_8|ENC_NA);
break;
case SDP_RTCP :
if (!ws_strtou16(attribute_value, NULL, &media_desc->control_port))
media_desc->control_port = 0; /* Just use default, if not legal port */
if (media_desc) {
if (!ws_strtou16(attribute_value, NULL, &media_desc->control_port))
media_desc->control_port = 0; /* Just use default, if not legal port */
}
break;
case SDP_RTCP_MUX :
media_desc->control_port = media_desc->media_port;
if (media_desc) {
media_desc->control_port = media_desc->media_port;
}
break;
default:
/* No special treatment for values of this attribute type, just add as one item. */