From 3ebf2e2d51576eac21363b25af47396f893c9294 Mon Sep 17 00:00:00 2001 From: Alexis La Goutte Date: Sun, 8 Sep 2019 18:48:01 +0000 Subject: [PATCH] Kafka: Fix Dead Store Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I3ac2e2b6a1ed7621f65f1a98e8b7b3704e8b299d Reviewed-on: https://code.wireshark.org/review/34481 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman --- epan/dissectors/packet-kafka.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/epan/dissectors/packet-kafka.c b/epan/dissectors/packet-kafka.c index e250b2205d..1f1260be66 100644 --- a/epan/dissectors/packet-kafka.c +++ b/epan/dissectors/packet-kafka.c @@ -1079,10 +1079,10 @@ dissect_kafka_string_new(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree pi = proto_tree_add_item(tree, hf_item, tvb, offset+len, (gint)val, ENC_NA | ENC_UTF_8); } else if (val == 0) { // there is empty payload (0 octets) - pi = proto_tree_add_string_format_value(tree, hf_item, tvb, offset+len, 0, NULL, ""); + proto_tree_add_string_format_value(tree, hf_item, tvb, offset+len, 0, NULL, ""); } else if (val == -1) { // there is no payload (null) - pi = proto_tree_add_string_format_value(tree, hf_item, tvb, offset+len, 0, NULL, ""); + proto_tree_add_string_format_value(tree, hf_item, tvb, offset+len, 0, NULL, ""); val = 0; } else { pi = proto_tree_add_string_format_value(tree, hf_item, tvb, offset+len, 0, NULL, ""); @@ -1134,13 +1134,13 @@ dissect_kafka_bytes_new(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree, val = 0; } else if (val > 0) { // there is payload available, possibly with 0 octets - pi = proto_tree_add_item(tree, hf_item, tvb, offset+len, (gint)val, ENC_NA); + proto_tree_add_item(tree, hf_item, tvb, offset+len, (gint)val, ENC_NA); } else if (val == 0) { // there is empty payload (0 octets) - pi = proto_tree_add_bytes_format_value(tree, hf_item, tvb, offset+len, 0, NULL, ""); + proto_tree_add_bytes_format_value(tree, hf_item, tvb, offset+len, 0, NULL, ""); } else if (val == -1) { // there is no payload (null) - pi = proto_tree_add_bytes_format_value(tree, hf_item, tvb, offset+len, 0, NULL, ""); + proto_tree_add_bytes_format_value(tree, hf_item, tvb, offset+len, 0, NULL, ""); val = 0; } else { pi = proto_tree_add_bytes_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "");