osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

GSM A DTAP: fix the bitmask of hf_gsm_a_dtap_test_loop 

According to 3GPP TS 44.014, section 8.1, type of the TCH loop is
edcoded in bits 2..6, so we should exclude bits 1, 7, and 8.

Before the patch:

  DTAP Tests Procedures Message Type: Close TCH Loop Cmd (0x00)
  Close TCH Loop Cmd Sub-channel
      ..00 0100 = Test Loop: C
      .... ...0 = Subchannel: Sub-channel 1 of two half rate channels is to be looped

after:

  DTAP Tests Procedures Message Type: Close TCH Loop Cmd (0x00)
  Close TCH Loop Cmd Sub-channel
      ..00 010. = Test Loop: C
      .... ...0 = Subchannel: Sub-channel 1 of two half rate channels is to be looped

Change-Id: Ie8ee23c6ce0a487d6a96b27324537372449946cb
Reviewed-on: https://code.wireshark.org/review/37981
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Vadim Yanitskiy 2020-07-29 06:01:45 +07:00 committed by Anders Broman
parent 2356415cfe
commit 3b230d5ea3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-gsm_a_dtap.c
View File

@ -8228,7 +8228,7 @@ proto_register_gsm_a_dtap(void)
},
{ &hf_gsm_a_dtap_test_loop,
{ "Test Loop", "gsm_a.dtap.test_loop",
FT_UINT8, BASE_DEC, NULL, 0x3f,
FT_UINT8, BASE_DEC, NULL, 0x3e,
NULL, HFILL }
},
{ &hf_gsm_a_dtap_subchannel,