osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Signal PDU: Speed up dissection 

This patch speeds up the dissection of signal pdus, if not filtering.
With an example trace file full of signal PDUs, I gained about a 4x
speed up in opening the trace.
This commit is contained in:
Dr. Lars Völker 2021-08-14 19:29:52 +02:00 committed by Wireshark GitLab Utility
parent c8d29e9f15
commit 322ae5037a
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
epan/dissectors/packet-signal-pdu.c
View File

@ -1550,16 +1550,24 @@ dissect_spdu_payload(tvbuff_t *tvb, packet_info *pinfo, proto_tree *root_tree, g
}
}
if (!spdu_derserializer_activated) {
spdu_signal_list_t *paramlist = get_parameter_config(id);
if (name == NULL && paramlist == NULL) {
/* unknown message, lets skip */
return 0;
}
if (root_tree == NULL && !proto_field_is_referenced(root_tree, proto_signal_pdu)) {
/* we only receive subtvbs with nothing behind us */
return tvb_captured_length(tvb);
}
if (paramlist == NULL || !spdu_derserializer_activated) {
/* we only receive subtvbs with nothing behind us */
return tvb_captured_length(tvb);
}
gint length = tvb_captured_length_remaining(tvb, 0);
spdu_signal_list_t *paramlist = get_parameter_config(id);
if (paramlist == NULL) {
return 0;
}
guint i;
for (i = 0; i < paramlist->num_of_items; i++) {