osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

wslua_listener: fix memleak in tap packet callback 

Addresses memleaks reported by ASAN for:

    test_wslua_listener
    test_wslua_nstime
    test_wslua_pinfo
    test_wslua_field

Change-Id: I221382844ee0bfd7ffc274bbb27eded0e221f9cf
Reviewed-on: https://code.wireshark.org/review/31742
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
This commit is contained in:
Peter Wu 2019-01-25 18:02:46 +01:00
parent a1ee099ffa
commit 311d087bbd
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
epan/wslua/wslua_listener.c
View File

@ -71,6 +71,7 @@ static int tap_packet_cb_error_handler(lua_State* L) {
static tap_packet_status lua_tap_packet(void *tapdata, packet_info *pinfo, epan_dissect_t *edt, const void *data) {
Listener tap = (Listener)tapdata;
tap_packet_status retval = TAP_PACKET_DONT_REDRAW;
TreeItem lua_tree_tap;
if (tap->packet_ref == LUA_NOREF) return TAP_PACKET_DONT_REDRAW; /* XXX - report error and return TAP_PACKET_FAILED? */
@ -90,7 +91,8 @@ static tap_packet_status lua_tap_packet(void *tapdata, packet_info *pinfo, epan_
lua_pinfo = pinfo;
lua_tvb = edt->tvb;
lua_tree = create_TreeItem(edt->tree, NULL);
lua_tree_tap = create_TreeItem(edt->tree, NULL);
lua_tree = lua_tree_tap;
switch ( lua_pcall(tap->L,3,1,1) ) {
case 0:
@ -115,6 +117,7 @@ static tap_packet_status lua_tap_packet(void *tapdata, packet_info *pinfo, epan_
lua_pinfo = NULL;
lua_tvb = NULL;
lua_tree = NULL;
g_free(lua_tree_tap);
return retval;
}