osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

SIGCOMP: Disable UDVM dissection and decompression. 

This dissector has had multiple, severe issues over the years. Set the
display.udvm.code and decomp.msg preferences to FALSE by default. Add
warnings about re-enabling them.

Change-Id: Ib23ab1b2cd23b35f2377416c7d197730dedbd9e2
Reviewed-on: https://code.wireshark.org/review/26002
Reviewed-by: Gerald Combs <gerald@wireshark.org>
This commit is contained in:
Gerald Combs 2018-02-22 11:36:51 -08:00
parent 05cd2b6c1c
commit 2e139a15fa
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
epan/dissectors/packet-sigcomp.c
View File

@ -165,10 +165,14 @@ static dissector_handle_t sigcomp_handle;
/* Default preference whether to display the bytecode in UDVM operands or not */
static gboolean display_udvm_bytecode = FALSE;
/* Default preference whether to dissect the UDVM code or not */
static gboolean dissect_udvm_code = TRUE;
/* WARNING: Setting this to true might result in the entire dissector being
disabled by default or removed completely. */
static gboolean dissect_udvm_code = FALSE;
static gboolean display_raw_txt = FALSE;
/* Default preference whether to decompress the message or not */
static gboolean decompress = TRUE;
/* WARNING: Setting this to true might result in the entire dissector being
disabled by default or removed completely. */
static gboolean decompress = FALSE;
/* Default preference whether to print debug info at execution of UDVM
* 0 = No printout
* 1 = details level 1