From 22fc5fb86502cbd42c92948eab542e551b963fd5 Mon Sep 17 00:00:00 2001 From: Gerald Combs Date: Tue, 27 Mar 2018 08:34:49 -0700 Subject: [PATCH] WiX: Options dialog updates. Remove GTK+. Add links to Npcap, WinPcap, and USBPcap. Move the capture options to the top of the options dialog. Replace group boxes with simple titles. Add an EditorConfig entry for our WiX files. Change-Id: Ibd581fa09f333fa84228f0a6f723ab62df85ee8e Reviewed-on: https://code.wireshark.org/review/27292 Reviewed-by: Anders Broman --- .editorconfig | 5 + packaging/wix/ComponentGroups.wxi | 314 +++----------------------- packaging/wix/Wireshark.wxs | 4 +- packaging/wix/WiresharkOptionsDlg.wxs | 113 ++++----- packaging/wix/WiresharkWixUI.wxs | 3 +- 5 files changed, 93 insertions(+), 346 deletions(-) diff --git a/.editorconfig b/.editorconfig index 987cfa7978..4d9aa6ff2c 100644 --- a/.editorconfig +++ b/.editorconfig @@ -25,6 +25,11 @@ indent_size = 8 indent_style = space indent_size = 4 +# WiX. The `xmllint --format` default is two spaces. +[*.wx?] +indent_style = spaces +indent_size = 2 + # C/C++ [*.{c,cpp,h}] indent_style = space diff --git a/packaging/wix/ComponentGroups.wxi b/packaging/wix/ComponentGroups.wxi index f6c70433c2..e430d1678e 100644 --- a/packaging/wix/ComponentGroups.wxi +++ b/packaging/wix/ComponentGroups.wxi @@ -635,7 +635,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -644,7 +644,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -653,7 +653,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -662,7 +662,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -671,7 +671,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -680,7 +680,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -689,7 +689,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -698,7 +698,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -707,7 +707,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -716,7 +716,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -725,7 +725,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -734,7 +734,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -743,7 +743,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -752,7 +752,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -761,7 +761,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -770,7 +770,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -779,7 +779,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -788,7 +788,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -797,7 +797,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -806,7 +806,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -815,7 +815,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -824,7 +824,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -833,7 +833,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -842,7 +842,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -851,7 +851,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -860,7 +860,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -869,7 +869,7 @@ - WIRESHARK_FILE_EXTENSIONS = "0" + WIRESHARK_FILE_EXTENSIONS = "1" @@ -878,270 +878,10 @@ - WIRESHARK_FILE_EXTENSIONS = "0" - - - - - - - - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - - - - - - - - WIRESHARK_FILE_EXTENSIONS = "1" - diff --git a/packaging/wix/Wireshark.wxs b/packaging/wix/Wireshark.wxs index 16ce53882c..a74a488636 100644 --- a/packaging/wix/Wireshark.wxs +++ b/packaging/wix/Wireshark.wxs @@ -14,7 +14,7 @@ --> - + @@ -22,7 +22,7 @@ - + + + + + + - - - - 3]]> - - - - 3]]> - - - - 3]]> - + + + + Download Npcap (recommended)]]> + + + + download WinPcap]]> + - - - - 3]]> - - - - 3]]> - - - - 3]]> - - + + + + Download USBPcap (experimental)]]> + - - - - - - - - - - - + + + + + 3]]> + + + + 3]]> + + + + 3]]> + - - - - - 1 - - - - + + + + + 3]]> + + + + + + + + + 1 + + + + diff --git a/packaging/wix/WiresharkWixUI.wxs b/packaging/wix/WiresharkWixUI.wxs index 789dccd6ba..e066d19890 100644 --- a/packaging/wix/WiresharkWixUI.wxs +++ b/packaging/wix/WiresharkWixUI.wxs @@ -31,6 +31,7 @@ Patch dialog sequence: + @@ -83,4 +84,4 @@ Patch dialog sequence: - \ No newline at end of file +